You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "markusmueller (via GitHub)" <gi...@apache.org> on 2023/12/27 14:54:09 UTC
[PR] SCIM attributes according to spec [directory-scimple]
markusmueller opened a new pull request, #481:
URL: https://github.com/apache/directory-scimple/pull/481
The classes ScimResource and Meta contain fields where the scim attributes are not set according to spec (mutability, case sensitivity and uniqueness).
It's currently not possible to overwrite these attributes in sub classes.
To be able to provide schemas according to spec this PR is changing the non conforming attributes to values as defined in https://datatracker.ietf.org/doc/html/rfc7643#section-3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] SCIM attributes according to spec [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on code in PR #481:
URL: https://github.com/apache/directory-scimple/pull/481#discussion_r1439782373
##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/resources/ScimResource.java:
##########
@@ -62,11 +63,11 @@ public abstract class ScimResource extends BaseResource<ScimResource> implements
@XmlElement
@Size(min = 1)
- @ScimAttribute(required = true, returned = Returned.ALWAYS, description = "A unique identifier for a SCIM resource as defined by the service provider.")
+ @ScimAttribute(required = true, returned = Returned.ALWAYS, mutability = Schema.Attribute.Mutability.READ_ONLY, uniqueness = Schema.Attribute.Uniqueness.SERVER, description = "A unique identifier for a SCIM resource as defined by the service provider.")
String id;
@XmlElement
- @ScimAttribute
+ @ScimAttribute(returned = Returned.DEFAULT, caseExact = true, mutability = Schema.Attribute.Mutability.READ_WRITE)
Review Comment:
Good catch, must have missed my IDEs warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] SCIM attributes according to spec [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #481:
URL: https://github.com/apache/directory-scimple/pull/481#issuecomment-1883389056
Thanks again @markusmueller!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] SCIM attributes according to spec [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #481:
URL: https://github.com/apache/directory-scimple/pull/481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] SCIM attributes according to spec [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #481:
URL: https://github.com/apache/directory-scimple/pull/481#discussion_r1439543083
##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/resources/ScimResource.java:
##########
@@ -62,11 +63,11 @@ public abstract class ScimResource extends BaseResource<ScimResource> implements
@XmlElement
@Size(min = 1)
- @ScimAttribute(required = true, returned = Returned.ALWAYS, description = "A unique identifier for a SCIM resource as defined by the service provider.")
+ @ScimAttribute(required = true, returned = Returned.ALWAYS, mutability = Schema.Attribute.Mutability.READ_ONLY, uniqueness = Schema.Attribute.Uniqueness.SERVER, description = "A unique identifier for a SCIM resource as defined by the service provider.")
String id;
@XmlElement
- @ScimAttribute
+ @ScimAttribute(returned = Returned.DEFAULT, caseExact = true, mutability = Schema.Attribute.Mutability.READ_WRITE)
Review Comment:
nit: The `returned` attribute could be removed as it's the default value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] SCIM attributes according to spec [directory-scimple]
Posted by "markusmueller (via GitHub)" <gi...@apache.org>.
markusmueller commented on code in PR #481:
URL: https://github.com/apache/directory-scimple/pull/481#discussion_r1439782373
##########
scim-spec/scim-spec-schema/src/main/java/org/apache/directory/scim/spec/resources/ScimResource.java:
##########
@@ -62,11 +63,11 @@ public abstract class ScimResource extends BaseResource<ScimResource> implements
@XmlElement
@Size(min = 1)
- @ScimAttribute(required = true, returned = Returned.ALWAYS, description = "A unique identifier for a SCIM resource as defined by the service provider.")
+ @ScimAttribute(required = true, returned = Returned.ALWAYS, mutability = Schema.Attribute.Mutability.READ_ONLY, uniqueness = Schema.Attribute.Uniqueness.SERVER, description = "A unique identifier for a SCIM resource as defined by the service provider.")
String id;
@XmlElement
- @ScimAttribute
+ @ScimAttribute(returned = Returned.DEFAULT, caseExact = true, mutability = Schema.Attribute.Mutability.READ_WRITE)
Review Comment:
Good catch, must have missed my IDEs warning. I have removed all the ``returned = Returned.DEFAULT`` instances.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org