You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2026/03/15 13:08:11 UTC
[PR] Use the loaded Comet extension too [datafusion-comet]
martin-g opened a new pull request, #3707:
URL: https://github.com/apache/datafusion-comet/pull/3707
## Which issue does this PR close?
Closes #.
## Rationale for this change
In the diff for Spark 3.5.8 variable `extensionClassNames` is initialized with the items of `extensionConfClassNames` and `loadCometExtension(sparkContext)` but then it is not used.
The diff for 3.4.3 does use it: https://github.com/apache/datafusion-comet/blob/9b773f344efed6bb9d6456046c0f2232010b008b/dev/diffs/3.4.3.diff#L99
## What changes are included in this PR?
Iterate of the items of `extensionClassNames`.
## How are these changes tested?
Run current test suite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Use the loaded Comet extension too (Spark 3.5.8) [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra merged PR #3707:
URL: https://github.com/apache/datafusion-comet/pull/3707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Use the loaded Comet extension too (Spark 3.5.8) [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #3707:
URL: https://github.com/apache/datafusion-comet/pull/3707#issuecomment-4091773201
Merged. Thanks @martin-g
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: Use the loaded Comet extension too (Spark 3.5.8) [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on PR #3707:
URL: https://github.com/apache/datafusion-comet/pull/3707#issuecomment-4086027665
> Previously those tests were excluded for Comet - [coderfender@24ee32e#diff-7917dac18d23e41523ceb1a298411e79bbf99d9349f885ac2c6c4ad81766265eR983-R984](https://github.com/coderfender/datafusion-comet/commit/24ee32e19a8b502ed1d3eedd4bb9ee7522e759c0#diff-7917dac18d23e41523ceb1a298411e79bbf99d9349f885ac2c6c4ad81766265eR983-R984) Should I exclude them again or dive deeper and debug/fix them ?
>
> Commit that removed the exclusion: [andygrove@adcfce4](https://github.com/andygrove/datafusion-comet/commit/adcfce468d63b2fd0b501128268a7aa1a958e7de)
We can exclude them for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org