You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/14 08:34:23 UTC
[GitHub] [incubator-doris] caoyang10 opened a new pull request #4352: Fix Bug: ES queries always route at same 3 BE nodes (#4351)
caoyang10 opened a new pull request #4352:
URL: https://github.com/apache/incubator-doris/pull/4352
Fix Issue:
https://github.com/apache/incubator-doris/issues/4351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caoyang10 commented on pull request #4352: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351)
Posted by GitBox <gi...@apache.org>.
caoyang10 commented on pull request #4352:
URL: https://github.com/apache/incubator-doris/pull/4352#issuecomment-674709611
I've obtained size = backendList.size() in the front of loop. Is it better?
please check the commit 6e17409
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #4352: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351)
Posted by GitBox <gi...@apache.org>.
wuyunfeng commented on a change in pull request #4352:
URL: https://github.com/apache/incubator-doris/pull/4352#discussion_r471245005
##########
File path: fe/fe-core/src/main/java/org/apache/doris/planner/EsScanNode.java
##########
@@ -224,7 +224,7 @@ private void assignBackends() throws UserException {
List<Backend> candidateBeList = Lists.newArrayList();
if (usingRandomBackend) {
for (int i = 0; i < numBe; ++i) {
- candidateBeList.add(backendList.get(beIndex++ % numBe));
+ candidateBeList.add(backendList.get(beIndex++ % backendList.size()));
Review comment:
```suggestion
candidateBeList.add(backendList.get(beIndex++ % size));
```
obtain size = backendList.size() in other place
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] wuyunfeng merged pull request #4352: [Doris On ES][Bug-Fix] ES queries always route at same 3 BE nodes (#4351)
Posted by GitBox <gi...@apache.org>.
wuyunfeng merged pull request #4352:
URL: https://github.com/apache/incubator-doris/pull/4352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org