[GitHub] rhtyd opened a new pull request #3134: keystore: restart systemvm cloud.service only when old keystore exist

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #3134: keystore: restart systemvm cloud.service only when old keystore exist
URL: https://github.com/apache/cloudstack/pull/3134
 
 
   This ensures that the systemvm agent (cloud.service) is not restarted
   when old keystore does not exist. However, on subsequent reboots of
   systemvm this will try to restart cloud.service after importing X509
   certificates.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   Deployed a CPU-bound environment (hypervisor host with limited CPU and 1core), saw that previously irrespective of keystore setup the restart logic would cause agent to restart (sig.kill is the reason seen in logs) and on management server side it would seem agent connects, then disconnects, then connects and is finally in `Up` state. With this fix, the reconnection attempt won't be observed on the management server side.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services