You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2014/04/13 20:27:30 UTC
svn commit: r1587069 - in
/commons/proper/net/trunk/src/test/java/org/apache/commons/net: ntp/ pop3/
telnet/ time/
Author: sebb
Date: Sun Apr 13 18:27:30 2014
New Revision: 1587069
URL: http://svn.apache.org/r1587069
Log:
Remove unecessary test Javadoc
- may cause IDE Javadoc warnings
- more to maintain
Modified:
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpClient.java Sun Apr 13 18:27:30 2014
@@ -33,9 +33,6 @@ public class TestNtpClient {
private static SimpleNTPServer server;
- /**
- * Start NTP server needed for the tests
- */
@BeforeClass
public static void oneTimeSetUp() throws IOException
{
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/pop3/POP3ConstructorTest.java Sun Apr 13 18:27:30 2014
@@ -21,7 +21,6 @@ import java.io.Reader;
/**
* @author <a href="mailto:commons-dev@apache.org">[Net]</a>
- * @version $Id$
*
* The POP3* tests all presume the existence of the following parameters:
* mailserver: localhost (running on the default port 110)
@@ -44,15 +43,12 @@ public class POP3ConstructorTest extends
String password = POP3Constants.password;
String mailhost = POP3Constants.mailhost;
- /**
- *
- */
public POP3ConstructorTest(String name)
{
super(name);
}
- /**
+ /*
* This test will ensure that the constants are not inadvertently changed.
* If the constants are changed in org.apache.commons.net.pop3 for some
* reason, this test will have to be updated.
@@ -81,10 +77,6 @@ public class POP3ConstructorTest extends
assertEquals(11, POP3Command.UIDL);
}
- /**
- * Test the default constructor
- *
- */
public void testPOP3DefaultConstructor()
{
POP3 pop = new POP3();
@@ -95,10 +87,6 @@ public class POP3ConstructorTest extends
assertNotNull(pop._replyLines);
}
- /*
- * Test the default constructor
- *
- */
public void testPOP3ClientStateTransition() throws Exception
{
POP3Client pop = new POP3Client();
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TelnetTestSimpleServer.java Sun Apr 13 18:27:30 2014
@@ -34,11 +34,12 @@ public class TelnetTestSimpleServer impl
Socket clientSocket = null;
Thread listener = null;
- /***
+ /*
* test of client-driven subnegotiation.
* <p>
* @param port - server port on which to listen.
- ***/
+ * @throws IOException on error
+ */
public TelnetTestSimpleServer(int port) throws IOException
{
serverSocket = new ServerSocket(port);
@@ -48,9 +49,6 @@ public class TelnetTestSimpleServer impl
listener.start();
}
- /***
- * Run for the thread. Waits for new connections
- ***/
// @Override
public void run()
{
@@ -97,9 +95,6 @@ public class TelnetTestSimpleServer impl
}
- /***
- * Disconnects the client socket
- ***/
public void disconnect()
{
if (clientSocket == null) {
@@ -118,9 +113,6 @@ public class TelnetTestSimpleServer impl
}
}
- /***
- * Stop the listener thread
- ***/
public void stop()
{
listener.interrupt();
@@ -134,9 +126,6 @@ public class TelnetTestSimpleServer impl
}
}
- /***
- * Gets the input stream for the client socket
- ***/
public InputStream getInputStream() throws IOException
{
if(clientSocket != null)
@@ -149,9 +138,6 @@ public class TelnetTestSimpleServer impl
}
}
- /***
- * Gets the output stream for the client socket
- ***/
public OutputStream getOutputStream() throws IOException
{
if(clientSocket != null)
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/telnet/TerminalTypeOptionHandlerTest.java Sun Apr 13 18:27:30 2014
@@ -16,16 +16,8 @@
*/
package org.apache.commons.net.telnet;
-/***
- * JUnit test class for TerminalTypeOptionHandler
- * <p>
- * @author Bruno D'Avanzo
- ***/
public class TerminalTypeOptionHandlerTest extends TelnetOptionHandlerTestAbstract
{
- /***
- * setUp for the test.
- ***/
@Override
protected void setUp()
{
@@ -34,9 +26,6 @@ public class TerminalTypeOptionHandlerTe
opthand3 = new TerminalTypeOptionHandler("ANSI", false, false, false, false);
}
- /***
- * test of the constructors.
- ***/
@Override
public void testConstructors()
{
@@ -44,10 +33,10 @@ public class TerminalTypeOptionHandlerTe
super.testConstructors();
}
- /***
+ /*
* test of client-driven subnegotiation.
* Checks that no subnegotiation is made.
- ***/
+ */
@Override
public void testStartSubnegotiation()
{
@@ -60,10 +49,10 @@ public class TerminalTypeOptionHandlerTe
}
- /***
+ /*
* test of client-driven subnegotiation.
* Checks that the terminal type is sent
- ***/
+ */
@Override
public void testAnswerSubnegotiation()
{
@@ -90,9 +79,9 @@ public class TerminalTypeOptionHandlerTe
}
- /***
+ /*
* compares two arrays of int
- ***/
+ */
protected boolean equalInts(int a1[], int a2[])
{
if(a1.length != a2.length)
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTCPClientTest.java Sun Apr 13 18:27:30 2014
@@ -29,9 +29,6 @@ public class TimeTCPClientTest extends T
private int _port = 3333; // default test port
- /***
- * open connections needed for the tests for the test.
- ***/
protected void openConnections() throws Exception
{
try {
@@ -47,7 +44,7 @@ public class TimeTCPClientTest extends T
server1.start();
}
- /***
+ /*
* tests the constant basetime used by TimeClient against tha
* computed from Calendar class.
*/
@@ -115,9 +112,6 @@ public class TimeTCPClientTest extends T
assertTrue(Math.abs(time2 - clientTime2) < 5000);
}
- /***
- * closes all the connections
- ***/
protected void closeConnections()
{
try
Modified: commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java?rev=1587069&r1=1587068&r2=1587069&view=diff
==============================================================================
--- commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java (original)
+++ commons/proper/net/trunk/src/test/java/org/apache/commons/net/time/TimeTestSimpleServer.java Sun Apr 13 18:27:30 2014
@@ -51,18 +51,11 @@ public class TimeTestSimpleServer implem
private final int port;
private boolean running = false;
- /**
- * Default constructor for TimetSimpleServer.
- * Initializes port to defaul time port.
- */
public TimeTestSimpleServer()
{
port = DEFAULT_PORT;
}
- /**
- * Constructor for TimetSimpleServer given a specific port.
- */
public TimeTestSimpleServer(int port)
{
this.port = port;
@@ -86,9 +79,8 @@ public class TimeTestSimpleServer implem
return running;
}
- /**
+ /*
* Start time service and provide time to client connections.
- * @throws IOException
*/
public void start() throws IOException
{
@@ -134,7 +126,7 @@ public class TimeTestSimpleServer implem
}
}
- /**
+ /*
* Close server socket.
*/
public void stop()