You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by "cdmikechen (via GitHub)" <gi...@apache.org> on 2023/06/17 11:12:32 UTC
[GitHub] [submarine] cdmikechen opened a new pull request, #1071: SUBMARINE-1131. Remove deprecated API for k8s 1.25
cdmikechen opened a new pull request, #1071:
URL: https://github.com/apache/submarine/pull/1071
### What is this PR for?
`PodSecurityPolicy` will be removed in k8s 1.25
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#psp-v125
So that we need to remove the `PodSecurityPolicy` support in 1.25 and try to use other ways to handle `runAsUser`.
https://kubernetes.io/docs/tasks/configure-pod-container/migrate-from-psp/
https://kubernetes.io/docs/concepts/security/pod-security-admission/
### What type of PR is it?
Improvement
### Todos
* [x] - Add k8s 1.25 in git workflow
* [x] - change `podSecurityPolicy.create` default value to false
* [ ] - Use another ways to hand `PodSecurityPolicy` in 1.25
### What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-1131
### How should this be tested?
CI test
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1071: SUBMARINE-1131. Remove deprecated API for k8s 1.25
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1071:
URL: https://github.com/apache/submarine/pull/1071#issuecomment-1595711569
## [Codecov](https://app.codecov.io/gh/apache/submarine/pull/1071?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1071](https://app.codecov.io/gh/apache/submarine/pull/1071?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2556d34) into [master](https://app.codecov.io/gh/apache/submarine/commit/be4ecf2c974bc834d851629a968a82651f8fa708?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (be4ecf2) will **decrease** coverage by `31.51%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1071 +/- ##
===========================================
- Coverage 75.98% 44.47% -31.51%
===========================================
Files 119 119
Lines 5000 4735 -265
===========================================
- Hits 3799 2106 -1693
- Misses 1201 2629 +1428
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `44.47% <ø> (-8.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 63 files with indirect coverage changes](https://app.codecov.io/gh/apache/submarine/pull/1071/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] cdmikechen commented on pull request #1071: SUBMARINE-1131. Remove deprecated API for k8s 1.25
Posted by "cdmikechen (via GitHub)" <gi...@apache.org>.
cdmikechen commented on PR #1071:
URL: https://github.com/apache/submarine/pull/1071#issuecomment-1602499786
@pingsutw
Hi~ For this PR, could you have time to do a validation in a k8s 1.25 environment (minikube or rancher) will work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1071: SUBMARINE-1131. Remove deprecated API for k8s 1.25
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #1071: SUBMARINE-1131. Remove deprecated API for k8s 1.25
URL: https://github.com/apache/submarine/pull/1071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org