You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Will Pierce (JIRA)" <ji...@apache.org> on 2011/03/15 12:59:29 UTC
[jira] Created: (THRIFT-1092) generated validate() method has wrong
indentation
generated validate() method has wrong indentation
-------------------------------------------------
Key: THRIFT-1092
URL: https://issues.apache.org/jira/browse/THRIFT-1092
Project: Thrift
Issue Type: Bug
Components: Python - Compiler
Affects Versions: 0.6
Reporter: Will Pierce
Priority: Minor
The generated validate() method is indented to the wrong level, making it an internal/unusable method inside the write() method of a struct
Looks like the line to generate the validator just needs to move down a couple lines, past an indent_down() call. I have a patch that fixes this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (THRIFT-1092) generated validate() method has wrong
indentation
Posted by "Will Pierce (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Pierce updated THRIFT-1092:
--------------------------------
Attachment: THRIFT-1092.python_validate_indent.patch
moves def validate(self) generation to the correct level, and inserts a newline between def write and def validate
> generated validate() method has wrong indentation
> -------------------------------------------------
>
> Key: THRIFT-1092
> URL: https://issues.apache.org/jira/browse/THRIFT-1092
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Affects Versions: 0.6
> Reporter: Will Pierce
> Priority: Minor
> Attachments: THRIFT-1092.python_validate_indent.patch
>
>
> The generated validate() method is indented to the wrong level, making it an internal/unusable method inside the write() method of a struct
> Looks like the line to generate the validator just needs to move down a couple lines, past an indent_down() call. I have a patch that fixes this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (THRIFT-1092) generated validate() method has wrong
indentation
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-1092.
---------------------------------
Resolution: Fixed
Fix Version/s: 0.7
Assignee: Will Pierce
I just committed this.
> generated validate() method has wrong indentation
> -------------------------------------------------
>
> Key: THRIFT-1092
> URL: https://issues.apache.org/jira/browse/THRIFT-1092
> Project: Thrift
> Issue Type: Bug
> Components: Python - Compiler
> Affects Versions: 0.6
> Reporter: Will Pierce
> Assignee: Will Pierce
> Priority: Minor
> Fix For: 0.7
>
> Attachments: THRIFT-1092.python_validate_indent.patch
>
>
> The generated validate() method is indented to the wrong level, making it an internal/unusable method inside the write() method of a struct
> Looks like the line to generate the validator just needs to move down a couple lines, past an indent_down() call. I have a patch that fixes this.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira