You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Attila Jeges (Code Review)" <ge...@cloudera.org> on 2020/10/09 14:47:41 UTC

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients 

Attila Jeges has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16573


Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................

IMPALA-10224: Add startup flag not to expose debug web url to clients

This patch introduces a new startup flag
--ping_expose_webserver_url (true by default) to control whether
PingImpalaService, PingImpalaHS2Service RPC calls should expose
the debug web url to the client or not.

This is necessary as the debug web UI is not something that
end-users will necessarily have access to.

If the flag is set to false, the RPC calls will return an empty
string instead of the real url signalling that the debug web ui
is not available.

Note that if the webserver is disabled (--enable_webserver flag
is set to false) the RPC calls will behave the same and return an
empty string for the url.

Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M tests/custom_cluster/test_web_pages.py
5 files changed, 48 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/16573/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 14:39:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................

IMPALA-10224: Add startup flag not to expose debug web url to clients

This patch introduces a new startup flag
--ping_expose_webserver_url (true by default) to control whether
PingImpalaService, PingImpalaHS2Service RPC calls should expose
the debug web url to the client or not.

This is necessary as the debug web UI is not something that
end-users will necessarily have access to.

If the flag is set to false, the RPC calls will return an empty
string instead of the real url signalling that the debug web ui
is not available.

Note that if the webserver is disabled (--enable_webserver flag
is set to false) the RPC calls will behave the same and return an
empty string for the url.

Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Reviewed-on: http://gerrit.cloudera.org:8080/16573
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M shell/impala_client.py
M shell/impala_shell.py
M tests/custom_cluster/test_web_pages.py
7 files changed, 62 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7398/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Oct 2020 15:11:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6560/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 05:34:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-10224: Add startup flag not to expose debug web url to clients
> It looks like one of the calls to print the query link in impala_shell is g
Good catch, thanks!

I've also noticed that there's another get_query_link() call in impala_client.py. I've added the guard there too.



-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 09:54:18 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Attila Jeges (Code Review)" <ge...@cloudera.org>.
Attila Jeges has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................

IMPALA-10224: Add startup flag not to expose debug web url to clients

This patch introduces a new startup flag
--ping_expose_webserver_url (true by default) to control whether
PingImpalaService, PingImpalaHS2Service RPC calls should expose
the debug web url to the client or not.

This is necessary as the debug web UI is not something that
end-users will necessarily have access to.

If the flag is set to false, the RPC calls will return an empty
string instead of the real url signalling that the debug web ui
is not available.

Note that if the webserver is disabled (--enable_webserver flag
is set to false) the RPC calls will behave the same and return an
empty string for the url.

Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
---
M be/src/runtime/exec-env.cc
M be/src/runtime/exec-env.h
M be/src/service/impala-beeswax-server.cc
M be/src/service/impala-hs2-server.cc
M shell/impala_client.py
M shell/impala_shell.py
M tests/custom_cluster/test_web_pages.py
7 files changed, 62 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/73/16573/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6563/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:11:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7436/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 10:18:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Oct 2020 09:11:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6557/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 18:00:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:59:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6557/


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 23:17:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 1:

(1 comment)

LGTM aside from one minor thing in the shell

http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16573/1//COMMIT_MSG@7
PS1, Line 7: IMPALA-10224: Add startup flag not to expose debug web url to clients
It looks like one of the calls to print the query link in impala_shell is guarded by "not self.webserver_address" but the other one for retried queries isn't.

So I think we need a minor fix for that in the shell too.

            data += "Retried query link: %s\n"\
                    % self.imp_client.get_query_link(retried_query_id)



-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Oct 2020 16:54:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10224: Add startup flag not to expose debug web url to clients

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16573 )

Change subject: IMPALA-10224: Add startup flag not to expose debug web url to clients
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16573
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ec3e92764d712b8fee63c1f45b038c31c184cfc
Gerrit-Change-Number: 16573
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 13 Oct 2020 17:59:59 +0000
Gerrit-HasComments: No