[GitHub] [nifi] joewitt commented on pull request #4993: NIFI-8412: Use proper log messages in PublishKafka(Record) processors

[GitBox <gi...@apache.org>]

joewitt commented on pull request #4993:
URL: https://github.com/apache/nifi/pull/4993#issuecomment-818408234


   The changes would be fine and I'd merge except you are now providing the exception data when we had originally not wanted to and are changing the log message such that it isn't making clear the transfer to the 'specified failure relationship'.
   
   For instance you changed
      getLogger().error("Failed to send messages to Kafka; will yield Processor and transfer FlowFiles to failure");
    To
                  getLogger().error("Failed to send messages to Kafka; will yield Processor due to {}", e);
   Instead lets just do the pattern you had already
                       getLogger().info("Failed to send FlowFile to kafka; will yield Processor and transfer flowfiles to specified failure strategy");
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org