You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2017/01/06 20:17:58 UTC

[jira] [Comment Edited] (HBASE-17337) list replication peers request should be routed through master

    [ https://issues.apache.org/jira/browse/HBASE-17337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15805632#comment-15805632 ] 

Enis Soztutar edited comment on HBASE-17337 at 1/6/17 8:17 PM:
---------------------------------------------------------------

For ReplicationPeerDescription, I would name it ReplicationPeerInfo, but it is up to you. 

bq. If user passes a pattern which doesn't match any existing peerIds, I think we should throw ReplicationPeerNotFoundException/IllegalArgumentException for it.
No, this is listing operation, as opposed to a get with with peer_id. We should not throw an exception even if there are no peers. 



was (Author: enis):
For ReplicationPeerDescription, I would name it ReplicationPeerInfo, but it is up to you. 

bq/ If user passes a pattern which doesn't match any existing peerIds, I think we should throw ReplicationPeerNotFoundException/IllegalArgumentException for it.
No, this is listing operation, as opposed to a get with with peer_id. We should not throw an exception even if there are no peers. 


> list replication peers request should be routed through master
> --------------------------------------------------------------
>
>                 Key: HBASE-17337
>                 URL: https://issues.apache.org/jira/browse/HBASE-17337
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-17337-v1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)