You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2020/01/22 18:31:09 UTC
[GitHub] [jena] superfell opened a new pull request #676: Fix thread safety
issue with HashMaps in TypeMapper
superfell opened a new pull request #676: Fix thread safety issue with HashMaps in TypeMapper
URL: https://github.com/apache/jena/pull/676
As raised on the dev mailing list, TypeMapper is a shared instance, but can mutate state stored in HashMaps, leading to potential issues.
One potential issue with this change is that HashMap allows null keys and ConcurrentHashMap does not. I've preserved the nullness behavior of TypeMappers public functions under the assumption that registering a type map for a null URI does't make sense. If that assumption is not valid, then this will need more work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #676: JENA-1827: Fix thread safety
issue with HashMaps in TypeMapper
Posted by GitBox <gi...@apache.org>.
afs merged pull request #676: JENA-1827: Fix thread safety issue with HashMaps in TypeMapper
URL: https://github.com/apache/jena/pull/676
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on issue #676: JENA-1827: Fix thread safety
issue with HashMaps in TypeMapper
Posted by GitBox <gi...@apache.org>.
afs commented on issue #676: JENA-1827: Fix thread safety issue with HashMaps in TypeMapper
URL: https://github.com/apache/jena/pull/676#issuecomment-577659539
The assumption that null is not registered is correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org