You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by "PragmaTwice (via GitHub)" <gi...@apache.org> on 2023/07/29 04:34:00 UTC

[GitHub] [kvrocks] PragmaTwice opened a new pull request, #1616: Remove .git in dockerignore

PragmaTwice opened a new pull request, #1616:
URL: https://github.com/apache/kvrocks/pull/1616

   If .git is ignored in docker container for building kvrocks, the built kvrocks binary will lose commit info, e.g.
   ```
   $ kvrocks -v
   kvrocks unstable
   ```
   instead of
   ```
   $ kvrocks -v
   kvrocks unstable (commit 1234567)
   ```
   
   It will hugely increase the difficulty to debug and locate problems.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kvrocks] PragmaTwice merged pull request #1616: Remove .git in dockerignore

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.

PragmaTwice merged PR #1616:
URL: https://github.com/apache/kvrocks/pull/1616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org