[GitHub] [samza] bkonold commented on a change in pull request #1403: SAMZA-2569: Add features into StreamAppender

[GitBox <gi...@apache.org>]

bkonold commented on a change in pull request #1403:
URL: https://github.com/apache/samza/pull/1403#discussion_r464700908



##########
File path: samza-log4j2/src/main/java/org/apache/samza/logging/log4j2/StreamAppender.java
##########
@@ -84,15 +87,17 @@
 
   protected static volatile boolean systemInitialized = false;
 
-  private Config config = null;
+  protected Config config = null;
   private SystemStream systemStream = null;
   private SystemProducer systemProducer = null;
   private String key = null;
-  private String streamName = null;
+  protected String streamName = null;
+  protected String appenderName = null;
+  private String containerName = null;
   private int partitionCount = 0;
   private boolean isApplicationMaster;
   private Serde<LogEvent> serde = null;
-  private Logger log = LogManager.getLogger(StreamAppender.class);
+  protected Logger log = LogManager.getLogger(StreamAppender.class);

Review comment:
       Sure we can keep the discussion there then circle back




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org