You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/11/14 18:14:34 UTC
Review Request 71769: Gracefully handled duplicated volumes from
non-conforming CSI plugins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71769/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Bugs: MESOS-9956
https://issues.apache.org/jira/browse/MESOS-9956
Repository: mesos
Description
-------
If the SLRP uses a plugin that does not conform to the CSI spec and
reports duplicated volumes, the duplicate would be removed.
This is a backport of `43b86da531a889b1c4b1d7ca6acb2eb924ea01e1`. We
are not backporting test changes as the original patch relies on
periodic plugin polling.
Diffs
-----
src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072
Diff: https://reviews.apache.org/r/71769/diff/1/
Testing
-------
`sudo make check` results in only known failures
Thanks,
Benjamin Bannier
Re: Review Request 71769: Gracefully handled duplicated volumes from
non-conforming CSI plugins.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71769/#review218643
-----------------------------------------------------------
Bad review!
Reviews applied: [71769]
Error:
2019-11-15 02:09:48 URL:https://reviews.apache.org/r/71769/diff/raw/ [5431/5431] -> "71769.patch" [1]
error: patch failed: src/resource_provider/storage/provider.cpp:656
error: src/resource_provider/storage/provider.cpp: patch does not apply
- Mesos Reviewbot
On Nov. 14, 2019, 6:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71769/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2019, 6:14 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9956
> https://issues.apache.org/jira/browse/MESOS-9956
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the SLRP uses a plugin that does not conform to the CSI spec and
> reports duplicated volumes, the duplicate would be removed.
>
> This is a backport of `43b86da531a889b1c4b1d7ca6acb2eb924ea01e1`. We
> are not backporting test changes as the original patch relies on
> periodic plugin polling.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072
>
>
> Diff: https://reviews.apache.org/r/71769/diff/1/
>
>
> Testing
> -------
>
> `sudo make check` results in only known failures
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71769: Gracefully handled duplicated volumes from
non-conforming CSI plugins.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71769/#review218669
-----------------------------------------------------------
Ship it!
Ship It!
- Benno Evers
On Nov. 14, 2019, 6:14 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71769/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2019, 6:14 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9956
> https://issues.apache.org/jira/browse/MESOS-9956
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the SLRP uses a plugin that does not conform to the CSI spec and
> reports duplicated volumes, the duplicate would be removed.
>
> This is a backport of `43b86da531a889b1c4b1d7ca6acb2eb924ea01e1`. We
> are not backporting test changes as the original patch relies on
> periodic plugin polling.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/provider.cpp 6d632606f411d3ca99d3573a57c9f68b02ba8072
>
>
> Diff: https://reviews.apache.org/r/71769/diff/1/
>
>
> Testing
> -------
>
> `sudo make check` results in only known failures
>
>
> Thanks,
>
> Benjamin Bannier
>
>