[GitHub] [kylin] zzcclp commented on a change in pull request #1716: KYLIN-4766 Cleanup segment storage after job be discarded

[GitBox <gi...@apache.org>]

zzcclp commented on a change in pull request #1716:
URL: https://github.com/apache/kylin/pull/1716#discussion_r684579656



##########
File path: kylin-spark-project/kylin-spark-common/src/main/java/org/apache/kylin/engine/spark/metadata/cube/PathManager.java
##########
@@ -58,12 +58,11 @@ public static String getSegmentParquetStoragePath(String hdfsWorkDir, String cub
     /**
      * Delete segment path
      */
-    public static boolean deleteSegmentParquetStoragePath(CubeInstance cube, CubeSegment segment) throws IOException {
-        if (cube == null || segment == null) {
+    public static boolean deleteSegmentParquetStoragePath(CubeInstance cube, String segmentName, String identifier) throws IOException {
+        if (cube == null) {

Review comment:
       it'd better check whether these two parameters 'segmentName' and 'identifier' are valid




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org