[jira] [Commented] (OOZIE-1837) LauncherMainHadoopUtils sensitive to clock skew

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14629013#comment-14629013 ] 

Hadoop QA commented on OOZIE-1837:
----------------------------------

Testing JIRA OOZIE-1837

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:red}-1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:red}-1{color} the patch does not add/modify any testcase
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
.    Tests run: 1682
.    Tests failed: 6
.    Tests errors: 0

.    The patch failed the following testcases:

.      testStreamingWithMultipleOozieServers_coordActionList(org.apache.oozie.service.TestZKXLogStreamingService)
.      testBundleStatusTransitWithLock(org.apache.oozie.service.TestStatusTransitService)
.      testAdminInstrumentation(org.apache.oozie.client.TestOozieCLI)
.      testMaxMatThrottleNotPicked(org.apache.oozie.service.TestCoordMaterializeTriggerService)
.      testActionKillCommandActionNumbers(org.apache.oozie.command.coord.TestCoordActionsKillXCommand)
.      testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)

{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/2445/

> LauncherMainHadoopUtils sensitive to clock skew
> -----------------------------------------------
>
>                 Key: OOZIE-1837
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1837
>             Project: Oozie
>          Issue Type: Bug
>         Environment: Oozie 4.0.0 (CDH5)
>            Reporter: Lars Francke
>            Assignee: Robert Kanter
>            Priority: Minor
>         Attachments: OOZIE-1837.001.patch
>
>
> The method {{getChildYarnJobs}} in {{LauncherMainHadoopUtils}} can fail with a message like {{begin > end in range (begin, end): (1399972474014, 1399972473948)}}.
> {code}
> startTime = Long.parseLong((System.getProperty("oozie.job.launch.time")));
> ....
> gar.setStartRange(startTime, System.currentTimeMillis());
> {code}
> I guess this is happening when the server on which the launch time was set has a different time then the one this task is running on. In our case there was a skew of about 8 seconds which caused all of our jobs that hit this server to fail.
> I understand that skew in clocks is generally not a good idea but I feel that Oozie could be a bit more resilient here or print a better warning maybe?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)