You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2026/09/12 01:58:52 UTC
[GH] (pekko/scala-2.13-idioms): Workflow run "Pull Requests" failed!
The GitHub Actions job "Pull Requests" on pekko.git/scala-2.13-idioms has failed.
Run started by GitHub user pjfanning (triggered by pjfanning).
Head commit for run:
b737f635a67c2ee581d1179d8b6475f28804978e / PJ Fanning <pj...@users.noreply.github.com>
chore: remove leftover Scala 2.12 idioms
Motivation:
The codebase still carried a number of Scala 2.12-era idioms that are
redundant or deprecated on Scala 2.13/3: `immutable.Seq` qualifiers
(`scala.Seq` has been `immutable.Seq` since 2.13), the deprecated
`mutable.WrappedArray` alias, `filterKeys`/`mapValues` on `Map`,
`Either` left/right projections, `.toIterator` and `Stream` in
user-facing doc snippets.
Modification:
- Replace `immutable.Seq` with `Seq` and drop the now-unused
`scala.collection.immutable` imports (same erasure, binary compatible).
- `ByteStringBuilder.addAll`: match `mutable.ArraySeq.ofByte` and
`immutable.ArraySeq.ofByte` instead of the deprecated
`WrappedArray.ofByte`; the immutable case previously fell through to
the generic path.
- Remove a dead commented-out `CanBuildFrom` block in `ByteString`.
- `ManifestInfo`: replace deprecated `filterKeys` with `filter`.
- `ShardRegion` scaladoc example: `filterKeys` -> `filter`.
- Doc snippets: `Stream.from(1)` -> `LazyList.from(1)`,
`buffer.toIterator` -> `buffer.iterator`.
- Tests: `Shrink.withLazyList`, `view.mapValues`, `.iterator`, and
plain `Either` equality instead of `.left.get`/`.right.get`.
Result:
No remaining 2.12 collection idioms in source and doc code. Build
definition under `project/` is intentionally left unchanged.
Tests:
- native scalafmt run on changed files
- sbt Test/compile, multi-jvm:compile in progress; relying on CI
References:
None - Scala 2.12 support was dropped previously
Report URL: https://github.com/apache/pekko/actions/runs/34666146429
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org