[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3844: ISSUE-3838: Wrong SSVM behavior causes redownloading for all the templates

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #3844: ISSUE-3838: Wrong SSVM behavior causes redownloading for all the templates
URL: https://github.com/apache/cloudstack/pull/3844#discussion_r373465580
 
 

 ##########
 File path: services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
 ##########
 @@ -850,10 +848,15 @@ private String getInstallPath(String jobId) {
 
         Script script = new Script(listVolScr, LOGGER);
         script.add("-r", rootdir);
-        ZfsPathParser zpp = new ZfsPathParser(rootdir);
-        script.execute(zpp);
-        result.addAll(zpp.getPaths());
-        LOGGER.info("found " + zpp.getPaths().size() + " volumes" + zpp.getPaths());
+        NfsPathParser parser = new NfsPathParser(rootdir);
+        script.execute(parser);
+        if (script.getExitValue() != 0) {
+            s_logger.error("Error while executing script " + script.toString());
+            throw new CloudRuntimeException("Error while executing script " + script.toString());
+        }
+        result.addAll(parser.getPaths());
+        s_logger.info("found " + parser.getPaths().size() + " volumes" + parser.getPaths());
 
 Review comment:
   LOGGER

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services