[GitHub] [beam] lukecwik commented on a diff in pull request #25104: Migrate portable runners to second version of data channel code

["lukecwik (via GitHub)" <gi...@apache.org>]

lukecwik commented on code in PR #25104:
URL: https://github.com/apache/beam/pull/25104#discussion_r1085694824


##########
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer2.java:
##########
@@ -253,15 +253,13 @@ public void onError(Throwable t) {
           "Failed to handle for {}",
           apiServiceDescriptor == null ? "unknown endpoint" : apiServiceDescriptor,
           t);
-      outboundObserver.onCompleted();
     }
 
     @Override
     public void onCompleted() {
       LOG.warn(
           "Hanged up for {}.",
           apiServiceDescriptor == null ? "unknown endpoint" : apiServiceDescriptor);
-      outboundObserver.onCompleted();
     }
   }
 }

Review Comment:
   Yeah, I wanted to do that in a separate CL since the commit history would be easier to understand.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org