[GitHub] [incubator-superset] etr2460 commented on a change in pull request #7736: Autocomplete in the table browser in SQL lab is broken

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #7736: Autocomplete in the table browser in SQL lab is broken
URL: https://github.com/apache/incubator-superset/pull/7736#discussion_r295536996
 
 

 ##########
 File path: superset/assets/src/components/TableSelector.jsx
 ##########
 @@ -130,7 +130,12 @@ export default class TableSelector extends React.PureComponent {
           `${encodeURIComponent(schema)}/${encodeURIComponent(substr)}/${forceRefresh}/`);
        return SupersetClient.get({ endpoint })
         .then(({ json }) => {
-          const filterOptions = createFilterOptions({ options: json.options });
+          const filterOptions = createFilterOptions({
+              options: json.options.map(o => ({
 
 Review comment:
   I don't think the linter actually checks for this (maybe we should add it) but in general the JS code uses 2 space indents

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org