You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Valentin Kulichenko (JIRA)" <ji...@apache.org> on 2016/04/11 00:15:25 UTC

[jira] [Comment Edited] (IGNITE-1102) IgniteSpringBean should have getConfiguration() method

    [ https://issues.apache.org/jira/browse/IGNITE-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234306#comment-15234306 ] 

Valentin Kulichenko edited comment on IGNITE-1102 at 4/10/16 10:14 PM:
-----------------------------------------------------------------------

Yes, that's exactly what I suggest. I just don't like that if this ever happens and assertions are disabled, user will get an NPE instead of explanatory exception. I would add a method that checks that Ignite instance is not null and call this method where needed.


was (Author: vkulichenko):
Yes, that's exactly what I suggest. I just don't like that if this ever happens and assertions are disabled, user will get an NPE instead of explanatory exception.

> IgniteSpringBean should have getConfiguration() method
> ------------------------------------------------------
>
>                 Key: IGNITE-1102
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1102
>             Project: Ignite
>          Issue Type: Bug
>          Components: general
>    Affects Versions: 1.1.4
>            Reporter: Valentin Kulichenko
>            Assignee: Saikat Maitra
>            Priority: Minor
>              Labels: newbie
>
> This is required for proper integration with Spring. See forum thread: http://apache-ignite-users.70518.x6.nabble.com/IgniteSpringBean-getter-method-for-IgniteConfiguration-td613.html
> I would also replace assertions with IllegalStateException throwing (same conditions and messages) since assertions looks weird on top level API class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)