You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@falcon.apache.org by ra...@apache.org on 2014/09/12 00:19:33 UTC
[28/41] git commit: FALCON-669 Missing optional workflow execution
listeners configuration results in NPE. Contributed by Raghav Kumar Gautam
FALCON-669 Missing optional workflow execution listeners configuration results in NPE. Contributed by Raghav Kumar Gautam
Project: http://git-wip-us.apache.org/repos/asf/incubator-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-falcon/commit/9aad374a
Tree: http://git-wip-us.apache.org/repos/asf/incubator-falcon/tree/9aad374a
Diff: http://git-wip-us.apache.org/repos/asf/incubator-falcon/diff/9aad374a
Branch: refs/heads/FALCON-585
Commit: 9aad374ab75ca477ada47c4bd2b0aaacd656602a
Parents: 331ad14
Author: Venkatesh Seetharam <ve...@apache.org>
Authored: Thu Sep 4 14:41:06 2014 -0700
Committer: Venkatesh Seetharam <ve...@apache.org>
Committed: Thu Sep 4 14:41:06 2014 -0700
----------------------------------------------------------------------
CHANGES.txt | 3 +++
.../falcon/workflow/WorkflowJobEndNotificationService.java | 5 +++++
2 files changed, 8 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/9aad374a/CHANGES.txt
----------------------------------------------------------------------
diff --git a/CHANGES.txt b/CHANGES.txt
index 1abbb67..4a3bbc4 100755
--- a/CHANGES.txt
+++ b/CHANGES.txt
@@ -77,6 +77,9 @@ Trunk (Unreleased)
OPTIMIZATIONS
BUG FIXES
+ FALCON-669 Missing optional workflow execution listeners configuration
+ results in NPE (Raghav Kumar Gautam via Venkatesh Seetharam)
+
FALCON-644 Falcon message producer masks errors in Post processing
(Venkatesh Seetharam)
http://git-wip-us.apache.org/repos/asf/incubator-falcon/blob/9aad374a/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
----------------------------------------------------------------------
diff --git a/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java b/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
index 67f6c79..fb2d58d 100644
--- a/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
+++ b/common/src/main/java/org/apache/falcon/workflow/WorkflowJobEndNotificationService.java
@@ -18,6 +18,7 @@
package org.apache.falcon.workflow;
+import org.apache.commons.lang.StringUtils;
import org.apache.falcon.FalconException;
import org.apache.falcon.aspect.GenericAlert;
import org.apache.falcon.entity.v0.SchemaHelper;
@@ -54,6 +55,10 @@ public class WorkflowJobEndNotificationService implements FalconService {
public void init() throws FalconException {
String listenerClassNames = StartupProperties.get().getProperty(
"workflow.execution.listeners");
+ if (StringUtils.isEmpty(listenerClassNames)) {
+ return;
+ }
+
for (String listenerClassName : listenerClassNames.split(",")) {
listenerClassName = listenerClassName.trim();
if (listenerClassName.isEmpty()) {