You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/03 10:20:40 UTC
[GitHub] [servicecomb-java-chassis] liubao68 opened a new pull request
#1555: [SCB-1643] add a slution to integrate with huaweicloud
liubao68 opened a new pull request #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-581351752
[](https://coveralls.io/builds/28493616)
Coverage decreased (-0.009%) to 85.349% when pulling **e2e77fcb18a862e1db633050281420b66cdaaecc on liubao68:highway** into **ffe64ad11f8758e3b61f7a091d95c03216ac8e2d on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] WillemJiang commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-583922131
How does the user use it?
It should be optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585072060
> > @WillemJiang I check the meaning of 'optional' in maven, this can not fullfil the purpose of the PR. By adding this, I want users include the file without notice to run across local and cloud. If 'optional' is defined, users still need to add this dependency in their pom. This is quite like not have this PR.
>
> 'optional' means it's not used by default, I'm not talking about the maven optional scope, I'm talking about if the user want to write the application to run with Huawei Cloud , he can add the dependency pom, but when we do the Apache release, we don't include this dependency pom by default.
```solution-basic``` is optional to users, they may not use this pom. The purpose of adding this pom is for easier of deploy. Or users will always be noticed to include the dependency and configure repositories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585013732
Users use it without notice. By adding this, samples provided in servicecomb-samples can run both in local and cloud
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] WillemJiang commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
WillemJiang commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585070548
> @WillemJiang I check the meaning of 'optional' in maven, this can not fullfil the purpose of the PR. By adding this, I want users include the file without notice to run across local and cloud. If 'optional' is defined, users still need to add this dependency in their pom. This is quite like not have this PR.
'optional' means it's not used by default, I'm not talking about the maven optional scope, I'm talking about if the user want to write the application to run with Huawei Cloud , he can add the dependency pom, but when we do the Apache release, we don't include this dependency pom by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1555:
[SCB-1643] add a slution to integrate with huaweicloud
Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1555: [SCB-1643] add a slution to integrate with huaweicloud
URL: https://github.com/apache/servicecomb-java-chassis/pull/1555#issuecomment-585065271
@WillemJiang I check the meaning of 'optional' in maven, this can not fullfil the purpose of the PR. By adding this, I want users include the file without notice to run across local and cloud. If 'optional' is defined, users still need to add this dependency in their pom. This is quite like not have this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services