You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/29 16:17:14 UTC
[GitHub] [spark] wangyum opened a new pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
wangyum opened a new pull request #29904:
URL: https://github.com/apache/spark/pull/29904
### What changes were proposed in this pull request?
This pr add `numRows` to metric of `BroadcastExchangeExec`.
### Why are the changes needed?
[`JoinEstimation.estimateInnerOuterJoin`](https://github.com/apache/spark/blob/d6a68e0b67ff7de58073c176dd097070e88ac831/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/JoinEstimation.scala#L55-L156) need row count. The [ShuffleExchangeExec](https://github.com/apache/spark/blob/1c6dff7b5fc171c190feea0d8f7d323e330d9151/sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala#L127) have added the row count, but `BroadcastExchangeExec` missing the row count.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #29904:
URL: https://github.com/apache/spark/pull/29904#discussion_r497557160
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -90,7 +91,8 @@ case class BroadcastExchangeExec(
override def runtimeStatistics: Statistics = {
val dataSize = metrics("dataSize").value
- Statistics(dataSize)
+ val numRows = metrics("numRows").value
+ Statistics(dataSize, Some(numRows))
Review comment:
It seems the PR description says nothing about this update, so could you describe it there?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #29904:
URL: https://github.com/apache/spark/pull/29904#discussion_r497953772
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/BroadcastExchangeExec.scala
##########
@@ -90,7 +91,8 @@ case class BroadcastExchangeExec(
override def runtimeStatistics: Statistics = {
val dataSize = metrics("dataSize").value
- Statistics(dataSize)
+ val numRows = metrics("numRows").value
+ Statistics(dataSize, Some(numRows))
Review comment:
Updated it to `This pr adds numRows to the metric and runtimeStatistics of BroadcastExchangeExec.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700990334
**[Test build #129246 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129246/testReport)** for PR 29904 at commit [`7084bd1`](https://github.com/apache/spark/commit/7084bd1e80ce74cae6a7807af771b96be19b5deb).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #29904:
URL: https://github.com/apache/spark/pull/29904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700863335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700863335
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700849154
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33863/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700991745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700863321
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/33863/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700815829
**[Test build #129246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129246/testReport)** for PR 29904 at commit [`7084bd1`](https://github.com/apache/spark/commit/7084bd1e80ce74cae6a7807af771b96be19b5deb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700815829
**[Test build #129246 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129246/testReport)** for PR 29904 at commit [`7084bd1`](https://github.com/apache/spark/commit/7084bd1e80ce74cae6a7807af771b96be19b5deb).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #29904: [SPARK-33026][SQL] Add numRows to metric of BroadcastExchangeExec
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #29904:
URL: https://github.com/apache/spark/pull/29904#issuecomment-700991745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org