[jira] [Commented] (THRIFT-2460) unopened socket fd must be less than zero.

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967188#comment-13967188 ] 

Jens Geyer commented on THRIFT-2460:
------------------------------------

According to http://pubs.opengroup.org/onlinepubs/009695399/functions/socket.html, it seems you are correct ("non-negative integer"). 
May I ask ...
 * ...  if by accident you already have a patch
 * ... whether you run into an real issue with the actual behaviour, or if you just spotted it by reading the code? 



> unopened socket fd must be less than zero.
> ------------------------------------------
>
>                 Key: THRIFT-2460
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2460
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Library
>    Affects Versions: 0.9.1
>            Reporter: Jaesang Kim
>
> ThriftSocket->sd is 0 when initialized.
> But socket() function return a fd number greater than *equal* 0.
> So, ThriftSocket->sd must be less than 0 in initialize function.



--
This message was sent by Atlassian JIRA
(v6.2#6252)