You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Matthias Wessendorf <ma...@apache.org> on 2009/03/27 08:11:16 UTC
[TRINIDAD] annoying servlet spec restriction for setting character
encoding after parameters have been retrieved...
Hi,
what do people think about this guy:
https://issues.apache.org/jira/browse/TRINIDAD-1434
A *possible* fix could be, to simple move this if:
<snip>
// If the encoding is already right, we can bail
if (encoding.equals(_encoding))
return;
</snip>
a little bit up, and only do the WARNING when the encoding is
different (after request parameters have been retrieved)...
I personally don't care that much, but every now and than, I am
getting bugs against the upload, because of this (bogus) warning...
;-)
-Matthias
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [TRINIDAD] annoying servlet spec restriction for setting
character encoding after parameters have been retrieved...
Posted by Matthias Wessendorf <ma...@apache.org>.
On Fri, Mar 27, 2009 at 6:37 PM, Blake Sullivan
<bl...@oracle.com> wrote:
> Matthias Wessendorf said the following On 3/27/2009 12:11 AM PT:
>>
>> Hi,
>>
>> what do people think about this guy:
>> https://issues.apache.org/jira/browse/TRINIDAD-1434
>>
>> A *possible* fix could be, to simple move this if:
>> <snip>
>> // If the encoding is already right, we can bail
>> if (encoding.equals(_encoding))
>> return;
>> </snip>
>>
>> a little bit up, and only do the WARNING when the encoding is
>> different (after request parameters have been retrieved)...
>>
>> I personally don't care that much, but every now and than, I am
>> getting bugs against the upload, because of this (bogus) warning...
>> ;-)
>>
>> -Matthias
>>
>>
>
> I think that we should move the check up so that we send fewer spurious
> warnings.
okay, let me do that next week.
-Matthias
>
> -- Blake Sullivan
>
>
--
Matthias Wessendorf
blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
Re: [TRINIDAD] annoying servlet spec restriction for setting character
encoding after parameters have been retrieved...
Posted by Blake Sullivan <bl...@oracle.com>.
Matthias Wessendorf said the following On 3/27/2009 12:11 AM PT:
> Hi,
>
> what do people think about this guy:
> https://issues.apache.org/jira/browse/TRINIDAD-1434
>
> A *possible* fix could be, to simple move this if:
> <snip>
> // If the encoding is already right, we can bail
> if (encoding.equals(_encoding))
> return;
> </snip>
>
> a little bit up, and only do the WARNING when the encoding is
> different (after request parameters have been retrieved)...
>
> I personally don't care that much, but every now and than, I am
> getting bugs against the upload, because of this (bogus) warning...
> ;-)
>
> -Matthias
>
>
I think that we should move the check up so that we send fewer spurious
warnings.
-- Blake Sullivan