[GitHub] [camel-k-runtime] lburgazzoli commented on a change in pull request #152: Knative related improvements

[GitBox <gi...@apache.org>]

lburgazzoli commented on a change in pull request #152: Knative related improvements
URL: https://github.com/apache/camel-k-runtime/pull/152#discussion_r333738871
 
 

 ##########
 File path: camel-knative/src/main/java/org/apache/camel/component/knative/KnativeEndpoint.java
 ##########
 @@ -93,17 +96,19 @@ public KnativeComponent getComponent() {
 
     @Override
     public Producer createProducer() throws Exception {
-        final String version = configuration.getCloudEventsSpecVersion();
-        final Processor ceProcessor = CloudEventsProcessors.forSpecversion(version).producerProcessor(this);
+        if (type == Knative.Type.event) {
+            throw new UnsupportedOperationException("knative `events` are supported only as consumer");
 
 Review comment:
   so the event type is also used to lookup the service definition from the knative environment json ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services