[GitHub] [hadoop] nandakumar131 commented on a change in pull request #986: [HDDS-1690] ContainerController should provide a way to retrieve cont…

[GitBox <gi...@apache.org>]

nandakumar131 commented on a change in pull request #986: [HDDS-1690] ContainerController should provide a way to retrieve cont…
URL: https://github.com/apache/hadoop/pull/986#discussion_r295333582
 
 

 ##########
 File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerController.java
 ##########
 @@ -140,4 +141,8 @@ private Handler getHandler(final Container container) {
   public Iterator<Container> getContainers() {
     return containerSet.getContainerIterator();
   }
+
+  public Iterator<Container> getContainersForVolume(String volumeUuid) {
 
 Review comment:
   Instead of `String` can we use `HddsVolume` as method argument?
   Then we can also rename the method to `public Iterator<Container> getContainers(HddsVolume volumeId)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org