You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/11/28 15:44:02 UTC
Re: Review Request 54106: changes to intercept and time mybatis
invocations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54106/#review157035
-----------------------------------------------------------
Looks like you've got two reviews intertwined here? Can you get these properly split up?
- Joshua Cohen
On Nov. 27, 2016, 10:20 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54106/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2016, 10:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Joshua Cohen, and Santhosh Kumar Shanmugham.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> __Modification to SlaUtil::percentile to compute percentiles by interpolation__
>
> The calculation of mttX (median-time-to-X) depends on the computation of percentile values. The current implementation does not behave nicely with a small sample size. For instance, for a given sample set of {50, 150}, 50-percentile is reported to be 50. Although, 100 seems a more appropriate return value.
>
> This patch uses Guava's Quantile for interpolation.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 263647e802b664fd3ea21cef8109fb7a9252356f
> src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java 156b9c0a2fa0c0ec4b7220d5ec2cc40c3e59d1d6
> src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java e7287cec28e7b8ca978c506bfe821f261bc0ac26
> src/main/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptor.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java eca1beebc906d3354d8c294ba466bc904bde98fa
> src/test/java/org/apache/aurora/scheduler/storage/db/InstrumentingInterceptorTest.java PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/storage/mem/InMemTaskStoreTest.java 2e560c0d565689703b282391fe49dbf213ee25dc
> src/test/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStoreTest.java 79999e19454568540c14f91808635bf8dff82bb3
>
> Diff: https://reviews.apache.org/r/54106/diff/
>
>
> Testing
> -------
>
> Tests added and modified to match the continuous distribution.
> I also exported the tests into excel and check the reports percentiles.
>
>
> Thanks,
>
> Reza Motamedi
>
>