You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "JackDrogon (via GitHub)" <gi...@apache.org> on 2024/01/25 13:00:34 UTC
[PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
JackDrogon opened a new pull request, #30386:
URL: https://github.com/apache/doris/pull/30386
## Proposed changes
Fix be cmake coverage linker flag
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910293190
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit 4fd507b3e16d7db6c6b464db9020a5e1038b1e53 with default session variables
Stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select: 13.6 seconds inserted 10000000 Rows, about 735K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910262604
TeamCity be ut coverage result:
Function Coverage: 36.25% (8610/23753)
Line Coverage: 28.35% (70470/248574)
Region Coverage: 27.32% (36362/133102)
Branch Coverage: 24.12% (18638/77278)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4fd507b3e16d7db6c6b464db9020a5e1038b1e53_4fd507b3e16d7db6c6b464db9020a5e1038b1e53/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1912937058
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910192157
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910259136
<details>
<summary>TPC-H: <b>Total hot run time: 38471 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4fd507b3e16d7db6c6b464db9020a5e1038b1e53, data reload: false
------ Round 1 ----------------------------------
q1 17601 5134 5235 5134
q2 2032 140 125 125
q3 10652 1158 1196 1158
q4 10214 788 765 765
q5 7736 3151 3072 3072
q6 198 120 119 119
q7 870 505 481 481
q8 9235 1912 1934 1912
q9 7266 6391 6337 6337
q10 8199 3052 3064 3052
q11 418 196 194 194
q12 348 190 186 186
q13 17975 3327 3337 3327
q14 232 217 209 209
q15 570 511 502 502
q16 446 381 374 374
q17 945 529 525 525
q18 7525 6923 6675 6675
q19 1578 1380 1376 1376
q20 577 291 289 289
q21 2711 2355 2421 2355
q22 370 304 319 304
Total cold run time: 107698 ms
Total hot run time: 38471 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5403 5331 5183 5183
q2 324 218 210 210
q3 3293 3148 3076 3076
q4 2090 2060 2026 2026
q5 6002 5900 5928 5900
q6 199 118 119 118
q7 2320 1807 1878 1807
q8 3226 3350 3364 3350
q9 8929 8864 8797 8797
q10 3883 3794 3795 3794
q11 567 440 472 440
q12 794 625 639 625
q13 16916 3137 3129 3129
q14 285 251 278 251
q15 552 501 498 498
q16 514 474 472 472
q17 2197 1759 1820 1759
q18 9429 16715 9665 9665
q19 23976 1570 1550 1550
q20 4577 1933 1892 1892
q21 14610 5451 5305 5305
q22 946 534 543 534
Total cold run time: 111032 ms
Total hot run time: 60381 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910278836
<details>
<summary>TPC-DS: <b>Total hot run time: 186461 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4fd507b3e16d7db6c6b464db9020a5e1038b1e53, data reload: false
query1 930 333 320 320
query2 6583 2055 1902 1902
query3 6696 201 193 193
query4 32495 22190 22169 22169
query5 4442 365 442 365
query6 251 150 172 150
query7 4616 267 261 261
query8 231 173 179 173
query9 8321 2601 2585 2585
query10 413 217 211 211
query11 17347 15526 15574 15526
query12 124 65 65 65
query13 1667 372 382 372
query14 10574 6965 6979 6965
query15 222 178 186 178
query16 5790 260 244 244
query17 963 469 470 469
query18 1799 253 246 246
query19 170 134 134 134
query20 67 66 63 63
query21 191 135 122 122
query22 4992 4754 4599 4599
query23 31516 30802 30751 30751
query24 11285 2798 2841 2798
query25 535 315 308 308
query26 883 148 147 147
query27 2861 281 292 281
query28 6162 1858 1836 1836
query29 939 632 617 617
query30 274 137 139 137
query31 931 746 732 732
query32 66 50 47 47
query33 592 215 210 210
query34 847 449 458 449
query35 909 781 799 781
query36 1311 1162 1197 1162
query37 91 58 56 56
query38 3369 3284 3359 3284
query39 1311 1271 1277 1271
query40 194 89 86 86
query41 36 36 35 35
query42 84 82 92 82
query43 512 473 479 473
query44 1064 714 711 711
query45 194 183 182 182
query46 1066 659 660 659
query47 1620 1564 1527 1527
query48 394 305 315 305
query49 1095 303 292 292
query50 673 317 309 309
query51 5364 5156 5206 5156
query52 90 78 72 72
query53 319 256 265 256
query54 240 178 189 178
query55 80 76 73 73
query56 170 169 171 169
query57 1026 961 931 931
query58 179 150 156 150
query59 2773 2555 2704 2555
query60 201 172 172 172
query61 81 93 80 80
query62 547 368 362 362
query63 285 259 258 258
query64 4163 1766 1761 1761
query65 3307 3256 3249 3249
query66 1212 316 302 302
query67 15759 15359 15185 15185
query68 11051 535 507 507
query69 571 290 289 289
query70 1660 1535 1502 1502
query71 10416 10194 10192 10192
query72 5077 2824 2807 2807
query73 2169 305 304 304
query74 6972 6379 6386 6379
query75 4599 2323 2346 2323
query76 6345 1060 1060 1060
query77 653 227 234 227
query78 9167 8939 8651 8651
query79 991 502 492 492
query80 539 319 315 315
query81 471 203 200 200
query82 172 74 80 74
query83 133 113 120 113
query84 274 67 68 67
query85 1085 331 331 331
query86 382 388 365 365
query87 3469 3336 3365 3336
query88 2965 2139 2140 2139
query89 420 367 354 354
query90 1973 182 181 181
query91 167 119 132 119
query92 51 43 44 43
query93 1733 445 433 433
query94 1284 158 158 158
query95 497 454 444 444
query96 624 321 309 309
query97 4261 4114 4194 4114
query98 191 189 185 185
query99 1016 699 714 699
Total cold run time: 296872 ms
Total hot run time: 186461 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1912937066
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "JackDrogon (via GitHub)" <gi...@apache.org>.
JackDrogon commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910175699
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #30386:
URL: https://github.com/apache/doris/pull/30386#issuecomment-1910288009
<details>
<summary>ClickBench: <b>Total hot run time: 30.67 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4fd507b3e16d7db6c6b464db9020a5e1038b1e53, data reload: false
query1 0.03 0.03 0.03
query2 0.06 0.02 0.02
query3 0.22 0.05 0.05
query4 1.70 0.07 0.10
query5 0.54 0.52 0.53
query6 1.27 0.63 0.64
query7 0.01 0.01 0.02
query8 0.04 0.03 0.03
query9 0.55 0.49 0.52
query10 0.56 0.56 0.56
query11 0.12 0.08 0.09
query12 0.10 0.09 0.10
query13 0.60 0.60 0.60
query14 0.78 0.80 0.80
query15 0.79 0.77 0.77
query16 0.36 0.38 0.39
query17 1.00 1.04 1.00
query18 0.25 0.22 0.25
query19 1.85 1.77 1.77
query20 0.01 0.01 0.00
query21 15.41 0.55 0.56
query22 2.49 1.82 1.61
query23 17.30 0.86 0.82
query24 2.49 1.30 0.95
query25 0.41 0.26 0.12
query26 0.51 0.13 0.13
query27 0.04 0.05 0.04
query28 11.15 0.75 0.74
query29 12.61 3.12 3.27
query30 0.51 0.48 0.48
query31 2.79 0.34 0.35
query32 3.39 0.49 0.49
query33 3.23 3.21 3.23
query34 15.84 4.32 4.31
query35 4.44 4.32 4.34
query36 1.12 1.07 1.07
query37 0.07 0.05 0.05
query38 0.04 0.03 0.02
query39 0.02 0.01 0.01
query40 0.15 0.14 0.13
query41 0.07 0.01 0.01
query42 0.02 0.01 0.02
query43 0.02 0.02 0.02
Total cold run time: 104.96 s
Total hot run time: 30.67 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](cmake) Fix be cmake coverage linker flag [doris]
Posted by "zy-kkk (via GitHub)" <gi...@apache.org>.
zy-kkk merged PR #30386:
URL: https://github.com/apache/doris/pull/30386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org