[jira] [Created] (TAP5-1802) Component tracing check should check if there is a request

["Denis Stepanov (Created) (JIRA)" <ji...@apache.org>]

Component tracing check should check if there is a request
----------------------------------------------------------

                 Key: TAP5-1802
                 URL: https://issues.apache.org/jira/browse/TAP5-1802
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.3
            Reporter: Denis Stepanov


In ComponentPageElementImpl there is a check if request has a parameter to enable component tracing:

   // should be okay since it's a shadow service object - NOT
    private final Request request;

    return !productionMode && (componentTracingEnabled || "true".equals(request.getParameter("t:component-trace")));

in a case when PageDocumentGenerator is used there is no request and shadow builder will throw an exception.

Solution would be to use RequestGlobals and check if there is a request. 






 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira