You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by mo...@apache.org on 2021/01/16 13:38:51 UTC
[incubator-doris] branch master updated: [Doc] Update
PULL_REQUEST_TEMPLATE.md (#5248)
This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-doris.git
The following commit(s) were added to refs/heads/master by this push:
new 6794dd0 [Doc] Update PULL_REQUEST_TEMPLATE.md (#5248)
6794dd0 is described below
commit 6794dd08bdb12ffb7ddf42d7a62965ce2502abf0
Author: Ting Sun <11...@mail.sustech.edu.cn>
AuthorDate: Sat Jan 16 21:38:38 2021 +0800
[Doc] Update PULL_REQUEST_TEMPLATE.md (#5248)
A reword suggestion.
Reasons: Before my change, the statement is "If this change need a document change, I have updated the document",
and there is a grammar error in it evidently: "change" cannot be paired with "need".
Either "changes need" or "change need" will be ok at the grammar level.
According to the context, "changes need" will be better.
Now, the statement is "If these changes need document changes, I have updated the document".
---
.github/PULL_REQUEST_TEMPLATE.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 42a5977..834dc43 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -20,7 +20,7 @@ _Put an `x` in the boxes that apply. You can also fill these out after creating
- [] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
-- [] If this change need a document change, I have updated the document
+- [] If these changes need document changes, I have updated the document
- [] Any dependent changes have been merged
## Further comments
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org