You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by EionRobb <gi...@git.apache.org> on 2014/06/21 23:43:40 UTC
[GitHub] cordova-android pull request: Fix for `android` not being in PATH ...
GitHub user EionRobb opened a pull request:
https://github.com/apache/cordova-android/pull/103
Fix for `android` not being in PATH check on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EionRobb/cordova-android patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/103.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #103
----
commit 4fc050088750766008d00db2c05d0c2b98dd0d49
Author: Eion Robb <ei...@robbmob.com>
Date: 2014-06-21T21:43:30Z
Fix for `android` not being in PATH check on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: Fix for `android` not being in PATH ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/103
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-android pull request: Fix for `android` not being in PATH ...
Posted by ankitjaininfo <gi...@git.apache.org>.
Github user ankitjaininfo commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/103#discussion_r14366860
--- Diff: bin/lib/check_reqs.js ---
@@ -81,7 +81,7 @@ module.exports.check_android = function() {
}
return Q();
}, function(stderr) {
- if (stderr.match(/command\snot\sfound/)) {
+ if (stderr.match(/command\snot\sfound/) || stderr.match(/is not recognized as an internal or external command/)) {
--- End diff --
Same kind of error, i found on ubuntu. The way to match regex shall break at may platforms. I have created a pull request so that it prints and error message for easier debug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---