You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/01 01:08:13 UTC
[GitHub] [skywalking] codecov-io commented on issue #4157: Add service type
from register and support browser as service type
codecov-io commented on issue #4157: Add service type from register and support browser as service type
URL: https://github.com/apache/skywalking/pull/4157#issuecomment-570011601
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=h1) Report
> Merging [#4157](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d38a8eaaa7e7193bff292cd03016c6a9320c8c9a?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4157 +/- ##
==========================================
- Coverage 26.9% 26.87% -0.04%
==========================================
Files 1160 1160
Lines 25341 25372 +31
Branches 3676 3678 +2
==========================================
Hits 6818 6818
- Misses 17916 17947 +31
Partials 607 607
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ugin/elasticsearch7/query/MetadataQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9NZXRhZGF0YVF1ZXJ5RXM3REFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ing/oap/server/core/register/ServiceInventory.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVnaXN0ZXIvU2VydmljZUludmVudG9yeS5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...plugin/elasticsearch/query/MetadataQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvTWV0YWRhdGFRdWVyeUVzREFPLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...king/oap/query/graphql/resolver/MetadataQuery.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcXVlcnktcGx1Z2luL3F1ZXJ5LWdyYXBocWwtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9xdWVyeS9ncmFwaHFsL3Jlc29sdmVyL01ldGFkYXRhUXVlcnkuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `44.94% <0%> (ø)` | :arrow_up: |
| [...ovider/handler/v6/grpc/RegisterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcmVnaXN0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvcmVnaXN0ZXIvcHJvdmlkZXIvaGFuZGxlci92Ni9ncnBjL1JlZ2lzdGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [.../skywalking/oap/server/core/register/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVnaXN0ZXIvTm9kZVR5cGUuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...ng/oap/server/core/query/MetadataQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcXVlcnkvTWV0YWRhdGFRdWVyeVNlcnZpY2UuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...ore/register/service/ServiceInventoryRegister.java](https://codecov.io/gh/apache/skywalking/pull/4157/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcmVnaXN0ZXIvc2VydmljZS9TZXJ2aWNlSW52ZW50b3J5UmVnaXN0ZXIuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=footer). Last update [d38a8ea...883f226](https://codecov.io/gh/apache/skywalking/pull/4157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services