You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Paul Stanton (JIRA)" <ji...@apache.org> on 2011/01/09 21:10:45 UTC

[jira] Created: (TAP5-1409) datefield - cannot select same day in different month

datefield - cannot select same day in different month
-----------------------------------------------------

                 Key: TAP5-1409
                 URL: https://issues.apache.org/jira/browse/TAP5-1409
             Project: Tapestry 5
          Issue Type: Bug
    Affects Versions: 5.2.4
            Reporter: Paul Stanton


say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.

use case:

initial date is 1/1/2011
1. open date picker
2. change month to feb
3. try to click on 1st of feb
- nothing happens. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072132#comment-13072132 ] 

Hudson commented on TAP5-1409:
------------------------------

Integrated in tapestry-trunk-freestyle #440 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/440/])
    TAP5-1408: datefield - cannot select same day in different month
TAP5-1409: datefield popup does not have option to cancel

robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1151673
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/DateFieldDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java


> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (Reopened) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reopened TAP5-1409:
----------------------------------


The bug with the datepicker closing when selecting a month from the drop down is still present; the test for it was checking the visibility too quickly, so the picker was still visible for the test, but would not be visible a few milliseconds later. 
                
> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TAP5-1409) datefield - cannot select same day in different month

Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979535#action_12979535 ] 

Paul Stanton commented on TAP5-1409:
------------------------------------

a workaround/patch is to remove the lines 345-348 in datepicker.js:

    if (this._selectedDate.getDate() != oDate.getDate() ||
        this._selectedDate.getMonth() != oDate.getMonth() ||
        this._selectedDate.getFullYear() != oDate.getFullYear() ||
        this._none)

however this does not solve the fact that the date is highlighted on all months, ie if you start with 1/1, then 2/1 and 3/1 and 4/1 etc will also be highlighted (css class "selected).

this patch also partially resolves TAP5-1408 as you can now close the popup by selecting the current date.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Closed] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler closed TAP5-1409.
--------------------------------


> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler resolved TAP5-1409.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

Datepicker now separates the concepts of the "calendar date" (the currently active month in the calendar" from the "selected date" (the date chosen by the user). It simplified a lot of the code and resolves this issue; also improved the "today" handling a bit.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "b kopelove (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095402#comment-13095402 ] 

b kopelove commented on TAP5-1409:
----------------------------------

This fix is great but it introduced a different bug.  When one clicks on the month name at the top of the calendar, a popup list of surrounding months is shown.  Upon clicking one of these months, the calendar disappears because the javascript thinks that you have clicked "outside" the calendar and exits.

I identified a simple fix to not exit when a popup month is selected:

---change:
331 	 if (parent.className == 'datePicker') { 

---to:
331 	 if (parent.className == 'datePicker' || parent.className == 'labelPopup') { 



> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057472#comment-13057472 ] 

Robert Zeigler commented on TAP5-1409:
--------------------------------------

But no test cases on the patch. :)

I'll be taking a slightly different tact for this problem, one that should also resolve the issue that the selected day-of-month is highlighted in other months, even if that day isn't selected.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (TAP5-1409) datefield - cannot select same day in different month

Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12979535#action_12979535 ] 

Paul Stanton commented on TAP5-1409:
------------------------------------

a workaround/patch is to remove the lines 345-348 in datepicker.js:

    if (this._selectedDate.getDate() != oDate.getDate() ||
        this._selectedDate.getMonth() != oDate.getMonth() ||
        this._selectedDate.getFullYear() != oDate.getFullYear() ||
        this._none)

however this does not solve the fact that the date is highlighted on all months, ie if you start with 1/1, then 2/1 and 3/1 and 4/1 etc will also be highlighted (css class "selected).

this patch also partially resolves TAP5-1408 as you can now close the popup by selecting the current date.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13072132#comment-13072132 ] 

Hudson commented on TAP5-1409:
------------------------------

Integrated in tapestry-trunk-freestyle #440 (See [https://builds.apache.org/job/tapestry-trunk-freestyle/440/])
    TAP5-1408: datefield - cannot select same day in different month
TAP5-1409: datefield popup does not have option to cancel

robertdzeigler : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1151673
Files : 
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/pages/DateFieldDemo.java
* /tapestry/tapestry5/trunk/tapestry-core/src/main/resources/org/apache/tapestry5/datepicker_106/js/datepicker.js
* /tapestry/tapestry5/trunk/tapestry-core/src/test/java/org/apache/tapestry5/integration/app1/FormTests.java


> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "b kopelove (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095402#comment-13095402 ] 

b kopelove commented on TAP5-1409:
----------------------------------

This fix is great but it introduced a different bug.  When one clicks on the month name at the top of the calendar, a popup list of surrounding months is shown.  Upon clicking one of these months, the calendar disappears because the javascript thinks that you have clicked "outside" the calendar and exits.

I identified a simple fix to not exit when a popup month is selected:

---change:
331 	 if (parent.className == 'datePicker') { 

---to:
331 	 if (parent.className == 'datePicker' || parent.className == 'labelPopup') { 



> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057472#comment-13057472 ] 

Robert Zeigler commented on TAP5-1409:
--------------------------------------

But no test cases on the patch. :)

I'll be taking a slightly different tact for this problem, one that should also resolve the issue that the selected day-of-month is highlighted in other months, even if that day isn't selected.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler closed TAP5-1409.
--------------------------------

    Resolution: Fixed

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler resolved TAP5-1409.
----------------------------------

    Resolution: Fixed
    
> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Antal van Kalleveen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antal van Kalleveen updated TAP5-1409:
--------------------------------------

    Attachment: datepicker.js

Attached 'datepicker.js' is a modified version which contains fixes for TAP-1408 and TAP-1409

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler closed TAP5-1409.
--------------------------------


> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Reopened] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reopened TAP5-1409:
----------------------------------


Re-opened to address month popup issue.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reassigned TAP5-1409:
------------------------------------

    Assignee: Robert Zeigler

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Antal van Kalleveen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Antal van Kalleveen updated TAP5-1409:
--------------------------------------

    Attachment: datepicker.js

Attached 'datepicker.js' is a modified version which contains fixes for TAP-1408 and TAP-1409

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler closed TAP5-1409.
--------------------------------

    Resolution: Fixed

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040531#comment-13040531 ] 

Paul Stanton commented on TAP5-1409:
------------------------------------

thanks for working on the patch antal,

the only remaining minor issue is that the selected date in other months is still highlighted.

your patch is good, cheers, p.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (Reopened) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reopened TAP5-1409:
----------------------------------


The bug with the datepicker closing when selecting a month from the drop down is still present; the test for it was checking the visibility too quickly, so the picker was still visible for the test, but would not be visible a few milliseconds later. 
                
> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Paul Stanton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13040531#comment-13040531 ] 

Paul Stanton commented on TAP5-1409:
------------------------------------

thanks for working on the patch antal,

the only remaining minor issue is that the selected date in other months is still highlighted.

your patch is good, cheers, p.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Reopened] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reopened TAP5-1409:
----------------------------------


Re-opened to address month popup issue.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler reassigned TAP5-1409:
------------------------------------

    Assignee: Robert Zeigler

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler resolved TAP5-1409.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 5.3

Datepicker now separates the concepts of the "calendar date" (the currently active month in the calendar" from the "selected date" (the date chosen by the user). It simplified a lot of the code and resolves this issue; also improved the "today" handling a bit.

> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (TAP5-1409) datefield - cannot select same day in different month

Posted by "Robert Zeigler (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Zeigler resolved TAP5-1409.
----------------------------------

    Resolution: Fixed
    
> datefield - cannot select same day in different month
> -----------------------------------------------------
>
>                 Key: TAP5-1409
>                 URL: https://issues.apache.org/jira/browse/TAP5-1409
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.2.4
>            Reporter: Paul Stanton
>            Assignee: Robert Zeigler
>             Fix For: 5.3
>
>         Attachments: datepicker.js
>
>
> say your date format is m/d/yyyy and the initial value is 1/1/2011 and you want to change it to 2/1/2011.. that is not possible. changing month, the selected 'day' is still selected and therefore not selectable.
> use case:
> initial date is 1/1/2011
> 1. open date picker
> 2. change month to feb
> 3. try to click on 1st of feb
> - nothing happens. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira