You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "lightzhao (via GitHub)" <gi...@apache.org> on 2023/06/16 10:17:10 UTC

[GitHub] [seatunnel] lightzhao opened a new pull request, #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

lightzhao opened a new pull request, #4940:
URL: https://github.com/apache/seatunnel/pull/4940

   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   #4920 
   When the commit fails, the hive partition should not be deleted. Deleting the partition will put the underlying data in the trash, so no operations should be performed on the partition, and only the currently written files should be rollback.
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] lightzhao commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1671041716

   > If no modifications are made, it seems this could lead to data loss since not all are new partitions. So, this is a bug currently, is my understanding correct?
   
   yes, data will be lost.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] EricJoy2048 commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1672599288

   @TyrantLucifer  PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] liugddx commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1595781231

   @TyrantLucifer PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] EricJoy2048 commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1672598824

   Yes, you can right. LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] ic4y commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1676645045

   @EricJoy2048 @TyrantLucifer PTAL, I've added a parameter for control.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] ic4y commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "ic4y (via GitHub)" <gi...@apache.org>.
ic4y commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1666461458

   If no modifications are made, it seems this could lead to data loss since not all are new partitions. So, this is a bug currently, is my understanding correct? @TyrantLucifer @lightzhao @EricJoy2048


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] EricJoy2048 merged pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [seatunnel] lightzhao commented on pull request #4940: [Improve][Connector-v2][HiveSink]remove drop partition when abort.

Posted by "lightzhao (via GitHub)" <gi...@apache.org>.
lightzhao commented on PR #4940:
URL: https://github.com/apache/seatunnel/pull/4940#issuecomment-1596360248

   > IMO,when user write new partitions this action is useful,2pc has all the lifecycle,add a parameter to control the action is better,not remove it. Default action is that not change the metadata of hive metastore.
   
   The partition will be loaded every commit. I don’t understand where abort is useful for the new partition. Now this operation has an impact on metadata and underlying data.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org