You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2022/01/19 02:40:35 UTC

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4289: [ZEPPELIN-5629] spark.driver.extraJavaOptions setting in %spark.conf does not work well

zjffdu commented on a change in pull request #4289:
URL: https://github.com/apache/zeppelin/pull/4289#discussion_r787305401



##########
File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
##########
@@ -77,6 +72,10 @@ public SparkInterpreterLauncher(ZeppelinConfiguration zConf, RecoveryStorage rec
         env.put(key, propValue);
       }
       if (isSparkConf(key, propValue)) {
+        if (Objects.equals("spark.driver.extraJavaOptions", key)) {

Review comment:
       It's better to add a comment explaining why handle `spark.driver.extraJavaOptions` in a specific way?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org