You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "Weiqing Yang (JIRA)" <ji...@apache.org> on 2018/10/17 00:21:00 UTC

[jira] [Commented] (SAMZA-1960) Refactor QueryTranslator unit tests

    [ https://issues.apache.org/jira/browse/SAMZA-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652713#comment-16652713 ] 

Weiqing Yang commented on SAMZA-1960:
-------------------------------------

[@srinipunuru|https://github.com/srinipunuru] [@atoomula|https://github.com/atoomula]

> Refactor QueryTranslator unit tests
> -----------------------------------
>
>                 Key: SAMZA-1960
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1960
>             Project: Samza
>          Issue Type: Bug
>          Components: sql
>            Reporter: Weiqing Yang
>            Priority: Major
>             Fix For: 0.15.0
>
>
> This Jira is to track the follow issues:
>  # Currently, the unit tests about "QueryTranslator" are using their own version of [translate|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L107](), the logic of which is a little messy. We should either use the translate() [here|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L126] or refactor the test version of [translate|https://github.com/apache/samza/blob/master/samza-sql/src/main/java/org/apache/samza/sql/translator/QueryTranslator.java#L107]() and its related unit tests.
>  # We should rename the package name of "[testutil|https://github.com/apache/samza/tree/master/samza-sql/src/main/java/org/apache/samza/sql/testutil]" to "util". 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)