[jira] [Created] (GEODE-20) DISCUSSION of Pull Request to Fix REST API

["Wes Williams (JIRA)" <ji...@apache.org>]

Wes Williams created GEODE-20:
---------------------------------

             Summary: DISCUSSION of Pull Request to Fix REST API
                 Key: GEODE-20
                 URL: https://issues.apache.org/jira/browse/GEODE-20
             Project: Geode
          Issue Type: Bug
          Components: general
    Affects Versions: 1.0.0.0-incubating
            Reporter: Wes Williams
            Assignee: William Markito Oliveira
             Fix For: 1.0.0.0-incubating


GitHub user wwilliams-pivotal opened a pull request:

    https://github.com/apache/incubator-geode/pull/2

    Allow REST web API to be launched. Eliminate duplicate code

    - Refactored duplicate code into a common class
    - Changed the return for the web rest dev api to return gemfire-web-api instead of gemfire-web
    - Applied standard formatting conventions against the existing classes per code policy
    - Added unit test to check for existence of gemfire-web-api jar

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wwilliams-pivotal/incubator-geode master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/2.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2

To make the review simpler, the only two material changes are below. All of the rest is/ (should be) duplicate code refactoring or source code formatting according to the conventions that Anthony sent out earlier.

ManagementAgent
-
-      //Find developer REST WAR file
-      final String gemfireAPIWar =  getGemFireAPIWarLocation(gemfireHome);
+
+      // Find developer REST WAR file
+      final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();


​RestAgent

-
-     final String gemfireAPIWar =  getGemFireAPIWarLocation(gemfireHome);
-    if(gemfireAPIWar == null){
-      logger.info("Unable to find GemFire Developer REST API WAR file; the Developer REST API for GemFire will not be exported and accessible.");
+    final String gemfireAPIWar = agentUtil.getGemFireWebApiWarLocation();
+    if (gemfireAPIWar == null) {




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)