You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/07 07:51:18 UTC
[GitHub] [incubator-tvm] jroesch opened a new pull request #6408: [Rust] Relay bindings
jroesch opened a new pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408
Add full bindings to the Relay AST, including the IRModule.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] mwillsey commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
mwillsey commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695036860
@gussmith23 unless things have changed on this branch, these work for me to build all of TVM and the rust bindings
```
export TVM_HOME= ...your tvm path...
export LLVM_CONFIG_PATH=$(which llvm-config)
export LD_LIBRARY_PATH="$TVM_HOME/build/"
export PYTHONPATH="$TVM_HOME/python:$TVM_HOME/topi/python:${PYTHONPATH}"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695031477
This may not be the correct PR to post this on, but currently I'm having to use TVM Rust bindings as follows:
```sh
$ RUSTFLAGS="-C link-args=-Wl,-rpath,/Users/gus/tvm/build" cargo test
```
I have to explicitly point my @rpath to my TVM location. What's the expected way to do this? Does this seem right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-696293396
@gussmith23 are you using an old version of LLVM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] binarybana commented on a change in pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
binarybana commented on a change in pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#discussion_r491135693
##########
File path: tests/scripts/task_python_docs.sh
##########
@@ -68,13 +68,19 @@ npm install
npm run typedoc
cd ..
+# Rust doc
+cd rust
+cargo doc --workspace --no-deps
Review comment:
🚀
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-688119210
cc @mwillsey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch edited a comment on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch edited a comment on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-688119210
cc @mwillsey @gussmith23
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-696293396
@gussmith23 are you using an old version of LLVM?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 edited a comment on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 edited a comment on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695031477
This may not be the correct PR to post this on, but currently I'm having to use TVM Rust bindings as follows:
```sh
$ RUSTFLAGS="-C link-args=-Wl,-rpath,/Users/gus/tvm/build" cargo test
```
I have to explicitly point my `@rpath` to my TVM location. What's the expected way to do this? Does this seem right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 edited a comment on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 edited a comment on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695128386
Hm, that mostly works, but I can't get rid of these warnings:
```
warning: couldn't execute `llvm-config --prefix` (error: No such file or directory (os error 2))
warning: set the LLVM_CONFIG_PATH environment variable to a valid `llvm-config` executable
```
I have the LLVM_CONFIG_PATH variable pointing to my llvm8 llvm-config binary, so I'm not sure what's going on
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-699463616
Closing in favor of #6563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jroesch closed pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
jroesch closed pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695898127
What's the thought on how tensor types should be represented? That's something I do need that doesn't seem to be implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695128386
Hm, that mostly works, but I can't get rid of these warnings:
```
warning: couldn't execute `llvm-config --prefix` (error: No such file or directory (os error 2))
warning: set the LLVM_CONFIG_PATH environment variable to a valid `llvm-config` executable
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] gussmith23 commented on pull request #6408: [Rust] Relay bindings
Posted by GitBox <gi...@apache.org>.
gussmith23 commented on pull request #6408:
URL: https://github.com/apache/incubator-tvm/pull/6408#issuecomment-695898127
What's the thought on how tensor types should be represented? That's something I do need that doesn't seem to be implemented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org