You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/11 05:18:08 UTC

[GitHub] [pulsar] leizhiyuan commented on a change in pull request #14217: allow user override subproperties for update properties

leizhiyuan commented on a change in pull request #14217:
URL: https://github.com/apache/pulsar/pull/14217#discussion_r804364160



##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/CreateSubscriptionTest.java
##########
@@ -275,10 +276,7 @@ public void addSubscriptionPropertiesTest() throws Exception {
         subscription4 = (PersistentSubscription) pulsar.getBrokerService()
                 .getTopicReference(topic).get().getSubscription(subName);
         properties4 = subscription4.getSubscriptionProperties();
-        assertTrue(properties4.containsKey("3"));
-        assertTrue(properties4.containsKey("4"));
-        assertEquals(properties4.get("3"), "3");
-        assertEquals(properties4.get("4"), "4");
+        assertTrue(properties4.isEmpty());

Review comment:
       ok,I will change it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org