[GitHub] [nifi] markap14 commented on a change in pull request #4190: NIFI-7300 Allowing narrow numeric types to fit againt schema check with wider type;

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #4190: NIFI-7300 Allowing narrow numeric types to fit againt schema check with wider type;
URL: https://github.com/apache/nifi/pull/4190#discussion_r405045719
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/RecordFieldType.java
 ##########
 @@ -364,4 +364,8 @@ public boolean isWiderThan(final RecordFieldType fieldType) {
     public static RecordFieldType of(final String typeString) {
       return SIMPLE_NAME_MAP.get(typeString);
     }
+
+    public Set<RecordFieldType> getNarrowDataTypes() {
+        return Collections.unmodifiableSet(narrowDataTypes);
 
 Review comment:
   Should make the member variable itself immutable instead of creating a new Set object to wrap the existing one for each invocation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services