You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/02 07:31:58 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #1776: csv::infer_file_schema remove redundant ref
tustvold opened a new pull request, #1776:
URL: https://github.com/apache/arrow-rs/pull/1776
# Which issue does this PR close?
Closes #.
# Rationale for this change
The `std::io::Read/Write/Seek` traits have blanket implementations for `&mut T` - see [here](https://doc.rust-lang.org/std/io/trait.Read.html#impl-Read-13) and so there is no reason to force callers to pass in an `&mut`. In fact it makes for worse ergonomics as it prevents passing in an owned type
# What changes are included in this PR?
Removes unnecessary `&mut`
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me commented on pull request #1776: csv::infer_file_schema remove redundant ref
Posted by GitBox <gi...@apache.org>.
nevi-me commented on PR #1776:
URL: https://github.com/apache/arrow-rs/pull/1776#issuecomment-1144593710
This leads to a compile failure :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #1776: csv::infer_file_schema remove redundant ref
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #1776:
URL: https://github.com/apache/arrow-rs/pull/1776#issuecomment-1144599037
Oops, serves me right for not testing :laughing:
Now we're just stuck on the fact Github Actions seems to having some issues....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #1776: csv::infer_file_schema remove redundant ref
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #1776:
URL: https://github.com/apache/arrow-rs/pull/1776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org