You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/09/08 22:48:29 UTC
[PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
rusackas opened a new pull request, #44031:
URL: https://github.com/apache/superset/pull/44031
### SUMMARY
Follow-up to #39386. That PR added a guard in `exportPivotExcel` (`superset-frontend/src/utils/downloadAsPivotExcel.ts`) for when the pivot table element can't be found in the DOM (e.g. it was unmounted mid-export), but the guard only logs to the console and returns, giving the user zero feedback that their download didn't happen. CodeAnt flagged this on #39386 itself after merge (major/incomplete-implementation).
The two sibling download utilities in the same directory, `downloadAsPdf.ts` and `downloadAsImage.tsx`, already handle their equivalent missing-element case by showing `addWarningToast(...)` in addition to logging. This PR brings `downloadAsPivotExcel.ts` in line with that existing convention, nothing else in `src/utils/download*.ts` needed the same fix.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A, this only affects the rare failure path (table missing from the DOM at export time); no visual change to the normal export flow.
### TESTING INSTRUCTIONS
```
npx jest superset-frontend/src/utils/downloadAsPivotExcel.test.ts
```
The updated "table element is not found" test now also asserts `addWarningToast` fires with the same message wording used by `downloadAsPdf`/`downloadAsImage`.
Manual: in Explore or a dashboard, trigger "Download as Excel" on a pivot table chart while the table is momentarily unmounted (e.g. mid-rerender); a warning toast should now appear instead of the download silently failing.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5627573028
Filed the follow-up: #44154. Same bound-callback treatment for `downloadAsPdf`/`downloadAsImage` that @gabotorresruiz flagged above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "gabotorresruiz (via GitHub)" <gi...@apache.org>.
gabotorresruiz commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3982193412
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -64,12 +65,20 @@ function restoreUnambiguousNumbers(sheet: WorkSheet): void {
export default function exportPivotExcel(
tableSelector: string,
fileName: string,
+ // Bound via `useToasts()`/`bindActionCreators`, not the raw action
+ // creator from `actions.ts`: this module has no dispatch of its own, so an
+ // unbound creator would only build a Redux action object and never render
+ // a toast.
+ addWarningToast?: (text: string) => void,
) {
const table = document.querySelector(tableSelector);
if (!table) {
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast?.(
Review Comment:
Not a blocker, and if anything it strengthens the case for the approach you landed here: I went to check the convention in the sibling utilities and found that their warning toasts never actually render. `downloadAsPdf.ts` imports the raw action creator and returns the action object from its event handler (line 59), which every caller discards, and `downloadAsImage.tsx` calls the raw creator and drops the result in four places (391, 436, 536, 617). The creators in `MessageToasts/actions.ts` are plain object factories, so without a dispatch nothing reaches the toast reducer, which is exactly what the first round of this PR hit.
So this file is now the only one of the three whose missing-element toast will actually show. Worth a follow-up applying the same bound-callback treatment to `downloadAsPdf`/`downloadAsImage`, with the same kind of test you added here? Happy to file it or take it if you'd rather keep this PR scoped.
##########
superset-frontend/src/utils/downloadAsPivotExcel.test.ts:
##########
@@ -124,12 +128,27 @@ test('leaves date-shaped strings as text rather than reinterpreting them as date
expect(sheet.C1).toMatchObject({ t: 's', v: 'not-a-date' });
});
-test('should log an error and return early when table element is not found', () => {
+test('logs an error, warns the user via the bound toast callback, and returns early when table element is not found', () => {
jest.spyOn(document, 'querySelector').mockReturnValue(null);
+ const addWarningToast = jest.fn();
- exportPivotExcel('.non-existent-selector', 'test-file');
+ exportPivotExcel('.non-existent-selector', 'test-file', addWarningToast);
expect(logging.error as jest.Mock).toHaveBeenCalledWith(
'[exportPivotExcel] No element found for selector: ".non-existent-selector"',
);
+ // Passed in already bound to dispatch (e.g. via `useToasts()`), so calling
+ // it directly is what actually renders the toast -- unlike the raw action
+ // creator, which only builds a Redux action object.
+ expect(addWarningToast).toHaveBeenCalledWith(
Review Comment:
Small heads-up on the open bot suggestion to add `expect(mockWriteFile).not.toHaveBeenCalled()` here: I tried it verbatim on this branch and it fails, because `mockWriteFile` still holds the calls from the four table-export tests above (the file's `afterEach` only restores spies, and there's no global `clearMocks`). If you want the early-return assertion, it needs a `mockWriteFile.mockClear()` at the top of this test first. Fine to skip it entirely too, the `not.toThrow` test below plus this one already pin the branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3973273110
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -70,6 +72,9 @@ export default function exportPivotExcel(
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast(
Review Comment:
Good catch, that was calling the raw action creator with no dispatch, so it never rendered anything. Fixed in 5d8e91b: `exportPivotExcel` now takes an optional bound toast callback, and both call sites wire it up via `useToasts()` (explore menu) or the existing `bindActionCreators` block (dashboard `Chart.tsx`), same pattern already used there for `addSuccessToast`/`addDangerToast`. Added a test for the no-callback case too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3984625369
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -64,12 +65,20 @@ function restoreUnambiguousNumbers(sheet: WorkSheet): void {
export default function exportPivotExcel(
tableSelector: string,
fileName: string,
+ // Bound via `useToasts()`/`bindActionCreators`, not the raw action
+ // creator from `actions.ts`: this module has no dispatch of its own, so an
+ // unbound creator would only build a Redux action object and never render
+ // a toast.
+ addWarningToast?: (text: string) => void,
) {
const table = document.querySelector(tableSelector);
if (!table) {
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast?.(
Review Comment:
Will address on a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #44031:
URL: https://github.com/apache/superset/pull/44031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5607522694
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 6e947bb5ae17b7f6d655042172720e8e8684eb97 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6aa1b2d3fce9960008ac0cf1 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-44031--superset-docs-preview.netlify.app](https://deploy-preview-44031--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DctBCoAgEEDRu8w6yQqiukHHGMexBEvJIYzo7rn7i_dfSFc8ksAC0IC58KS9tvOlTf6OorgQB3X4nP25KUETWEnELJVbTiE-q63DiNiZ3g6OeJ5HrfWEpMl18P0) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-44031--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5593070629
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/44031?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.85%. Comparing base ([`e6d088d`](https://app.codecov.io/gh/apache/superset/commit/e6d088d6b1bf460dcb0653eb539f606893b4283a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b6ad51b`](https://app.codecov.io/gh/apache/superset/commit/b6ad51b7c54ef4488e5cb3d497e9e6dc1a5c9cb2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 2 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #44031 +/- ##
==========================================
- Coverage 79.85% 79.85% -0.01%
==========================================
Files 2916 2915 -1
Lines 170703 170715 +12
Branches 39553 39564 +11
==========================================
+ Hits 136319 136327 +8
- Misses 31867 31871 +4
Partials 2517 2517
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/44031/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/44031/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.37% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/44031?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5592942410
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3984628078
##########
superset-frontend/src/utils/downloadAsPivotExcel.test.ts:
##########
@@ -124,12 +128,27 @@ test('leaves date-shaped strings as text rather than reinterpreting them as date
expect(sheet.C1).toMatchObject({ t: 's', v: 'not-a-date' });
});
-test('should log an error and return early when table element is not found', () => {
+test('logs an error, warns the user via the bound toast callback, and returns early when table element is not found', () => {
jest.spyOn(document, 'querySelector').mockReturnValue(null);
+ const addWarningToast = jest.fn();
- exportPivotExcel('.non-existent-selector', 'test-file');
+ exportPivotExcel('.non-existent-selector', 'test-file', addWarningToast);
expect(logging.error as jest.Mock).toHaveBeenCalledWith(
'[exportPivotExcel] No element found for selector: ".non-existent-selector"',
);
+ // Passed in already bound to dispatch (e.g. via `useToasts()`), so calling
+ // it directly is what actually renders the toast -- unlike the raw action
+ // creator, which only builds a Redux action object.
+ expect(addWarningToast).toHaveBeenCalledWith(
Review Comment:
Will investigate on the follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5595653868
<!-- Bito Reply -->
The current implementation of `addWarningToast` in `downloadAsPivotExcel.ts` is indeed just an action creator, which does not trigger the toast display on its own. To make this functional, you should use a dispatch-bound version of the action.
Since `exportPivotExcel` is a standard function and not a React component or hook, you would typically need to access the Redux store's `dispatch` method directly. If you have access to the store instance, you can wrap the call like this:
```typescript
import { store } from 'src/views/store'; // Adjust path to your store
// ...
store.dispatch(addWarningToast(t('Pivot table download failed, please refresh and try again.')));
```
Alternatively, if you prefer to keep the utility decoupled from the store, you could refactor `exportPivotExcel` to accept a `dispatch` function as an argument, allowing the caller to provide the necessary dispatch capability.
**superset-frontend/src/utils/downloadAsPivotExcel.ts**
```
store.dispatch(addWarningToast(t('Pivot table download failed, please refresh and try again.')));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #44031:
URL: https://github.com/apache/superset/pull/44031#discussion_r3964552774
##########
superset-frontend/src/utils/downloadAsPivotExcel.ts:
##########
@@ -70,6 +72,9 @@ export default function exportPivotExcel(
logging.error(
`[exportPivotExcel] No element found for selector: "${tableSelector}"`,
);
+ addWarningToast(
Review Comment:
Calling `addWarningToast` here only creates a Redux action object; this utility has no dispatch and discards it, so the missing-table path still returns without a user-visible toast. Could this use a dispatch-bound toast callback (and exercise the rendered toast) instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(explore): surface a toast when pivot Excel export can't find the table [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #44031:
URL: https://github.com/apache/superset/pull/44031#issuecomment-5614593283
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers an incremental AI Review.
- `/review full` - Manually triggers a full AI Review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org