[jira] [Commented] (LUCENE-6086) Minor optimizations to the encoding of numerics in stored fields

["Ryan Ernst (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-6086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232406#comment-14232406 ] 

Ryan Ernst commented on LUCENE-6086:
------------------------------------

Very cool!

Some thoughts:
* Do we really need to zigzag encode the special case of ints \[-63,63\] in floats/doubles? Since we have the 7 bits there, could we just offset by 63? ie {{0x80 == -63}}
* The comments in {{readZDouble}} and {{writeZDouble}} about the range for short int values don't match? I think the one in the write method is correct?
* I think reading code with masks is easier with constants, so maybe change {{header & (1 << 5)}} in {{readZLong}} to {{header & 0x10}}? 

> Minor optimizations to the encoding of numerics in stored fields
> ----------------------------------------------------------------
>
>                 Key: LUCENE-6086
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6086
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 5.0
>
>         Attachments: LUCENE-6086.patch
>
>
> LUCENE-5914 explored minor optimizations for numeric encoding in stored fields, I think we should try to push them to the default format.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org