You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aleksandr-dudko (via GitHub)" <gi...@apache.org> on 2023/08/31 13:24:43 UTC
[GitHub] [beam] aleksandr-dudko opened a new pull request, #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Dataflow_Examples_Java11
aleksandr-dudko opened a new pull request, #28257:
URL: https://github.com/apache/beam/pull/28257
The following jenkins job has been migrated:
https://ci-beam.apache.org/view/PostCommit/job/beam_PostCommit_Java11_Examples_Dataflow/
How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
by adding a comment to the PR
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Dataflow_Examples_Java11
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28257:
URL: https://github.com/apache/beam/pull/28257#issuecomment-1704892121
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Dataflow_Examples_Java11
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #28257:
URL: https://github.com/apache/beam/pull/28257#discussion_r1314894007
##########
.github/workflows/beam_PostCommit_Java_Dataflow_Examples_Java11.yml:
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java Dataflow Examples Java11
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_PostCommit_Java:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 180
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_Dataflow_Examples_Java11]
+ job_phrase: [Run Java examples on Dataflow Java 11]
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java examples on Dataflow Java 11'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java
+ uses: actions/setup-java@v3.8.0
+ with:
+ distribution: 'temurin'
+ java-version: '11'
+ - name: run PostCommit Java script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :runners:google-cloud-dataflow-java:examples:java11PostCommit
+ arguments: |
+ -PcompileAndRunTestsWithJava11 \
+ -Pjava11Home=$JAVA_HOME_11_X64 \
+ default-arguments: |
+ --continue \
Review Comment:
Here is the example of Jenkins gradle task:
`22:01:07 [src] $ /home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java11_Examples_Dataflow/src/gradlew --continue --max-workers=6 -Dorg.gradle.jvmargs=-Xms2g -Dorg.gradle.jvmargs=-Xmx4g :runners:google-cloud-dataflow-java:examples:java11PostCommit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] magicgoody commented on a diff in pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Dataflow_Examples_Java11
Posted by "magicgoody (via GitHub)" <gi...@apache.org>.
magicgoody commented on code in PR #28257:
URL: https://github.com/apache/beam/pull/28257#discussion_r1311652225
##########
.github/workflows/beam_PostCommit_Java_Dataflow_Examples_Java11.yml:
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java Dataflow Examples Java11
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_PostCommit_Java:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 180
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_Dataflow_Examples_Java11]
+ job_phrase: [Run Java examples on Dataflow Java 11]
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java examples on Dataflow Java 11'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java
+ uses: actions/setup-java@v3.8.0
+ with:
+ distribution: 'temurin'
+ java-version: '11'
+ - name: run PostCommit Java script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :runners:google-cloud-dataflow-java:examples:java11PostCommit
+ arguments: |
+ -PcompileAndRunTestsWithJava11 \
+ -Pjava11Home=$JAVA_HOME_11_X64 \
+ default-arguments: |
+ --continue \
Review Comment:
./.github/actions/gradle-command-self-hosted-action
"--continue" argument is integrated in this action already
do we need to specify it again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Examples_Dataflow_Java11
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #28257:
URL: https://github.com/apache/beam/pull/28257#discussion_r1316061278
##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_Java11.yml:
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java Examples Dataflow Java11
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Java_Examples_Dataflow_Java11:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 180
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_Examples_Dataflow_Java11]
+ job_phrase: [Run Java examples on Dataflow Java 11]
+ if: |
+ github.event_name == 'push' ||
Review Comment:
There is no `push` event for PostCommit jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Dataflow_Examples_Java11
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #28257:
URL: https://github.com/apache/beam/pull/28257#discussion_r1314888956
##########
.github/workflows/beam_PostCommit_Java_Dataflow_Examples_Java11.yml:
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java Dataflow Examples Java11
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+jobs:
+ beam_PostCommit_Java:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 180
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_Dataflow_Examples_Java11]
+ job_phrase: [Run Java examples on Dataflow Java 11]
+ if: |
+ github.event_name == 'push' ||
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java examples on Dataflow Java 11'
+ steps:
+ - uses: actions/checkout@v3
+ - name: Setup repository
+ uses: ./.github/actions/setup-action
+ with:
+ comment_phrase: ${{ matrix.job_phrase }}
+ github_token: ${{ secrets.GITHUB_TOKEN }}
+ github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
+ - name: Set up Java
+ uses: actions/setup-java@v3.8.0
+ with:
+ distribution: 'temurin'
+ java-version: '11'
+ - name: run PostCommit Java script
+ uses: ./.github/actions/gradle-command-self-hosted-action
+ with:
+ gradle-command: :runners:google-cloud-dataflow-java:examples:java11PostCommit
+ arguments: |
+ -PcompileAndRunTestsWithJava11 \
+ -Pjava11Home=$JAVA_HOME_11_X64 \
+ default-arguments: |
+ --continue \
Review Comment:
@magicgoody
Yes, it's an interesting job in terms of task parameters. They are different from those specified in our 'gradle-command-self-hosted-action'.
For example, in our action, there is a parameter and value:
"-Dorg.gradle.jvmargs=-Xmx6g", however in the Jenkins job, it's "Dorg.gradle.jvmargs=-Xmx4g". Also, in Jenkins, there is no "-Pdocker-pull-licenses".
That's why I simply overrode the value of the "default arguments".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Examples_Dataflow_Java11
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #28257:
URL: https://github.com/apache/beam/pull/28257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aleksandr-dudko commented on a diff in pull request #28257: Add GitHub Workflow Replacement for Jenkins job_PostCommit_Java_Examples_Dataflow_Java11
Posted by "aleksandr-dudko (via GitHub)" <gi...@apache.org>.
aleksandr-dudko commented on code in PR #28257:
URL: https://github.com/apache/beam/pull/28257#discussion_r1316894163
##########
.github/workflows/beam_PostCommit_Java_Examples_Dataflow_Java11.yml:
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java Examples Dataflow Java11
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.sha || github.head_ref || github.ref }}-${{ github.event.sender.login }}-${{ github.event.schedule }}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: read
+ checks: read
+ contents: read
+ deployments: read
+ id-token: none
+ issues: read
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Java_Examples_Dataflow_Java11:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 180
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_Examples_Dataflow_Java11]
+ job_phrase: [Run Java examples on Dataflow Java 11]
+ if: |
+ github.event_name == 'push' ||
Review Comment:
It's done. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org