You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Paul Rogers (Code Review)" <ge...@cloudera.org> on 2018/11/30 23:49:37 UTC
[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes
Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12017
Change subject: IMPALA-7914: Base interface for statement-like AST nodes
......................................................................
IMPALA-7914: Base interface for statement-like AST nodes
In order to integrate expression rewrites into the analysis phase, the
expression analyze() operation must be able to replace one expression
node with another. But, statements are analyzed in place. The result is
that statement-like nodes and expression nodes need different analyze()
semantics.
To prepare for that goal, this patch introduces a new StmtNode interface
as the base for all statement-like AST nodes. The existing analyze()
method moves to StmtNode. While Expr still defines this method for now,
the future goal is to change the Expr analyze() semantics.
Tests: This is purely a code restructuring, no functional changes. Reran
all FE tests.
Change-Id: I39dc783ee1535da5fad8ee2f2dd5f8ca17004bbc
---
M fe/src/main/java/org/apache/impala/analysis/Expr.java
M fe/src/main/java/org/apache/impala/analysis/FromClause.java
M fe/src/main/java/org/apache/impala/analysis/FunctionArgs.java
M fe/src/main/java/org/apache/impala/analysis/HdfsCachingOp.java
M fe/src/main/java/org/apache/impala/analysis/KuduPartitionParam.java
M fe/src/main/java/org/apache/impala/analysis/ParseNode.java
A fe/src/main/java/org/apache/impala/analysis/Parser.java
M fe/src/main/java/org/apache/impala/analysis/PartitionDef.java
M fe/src/main/java/org/apache/impala/analysis/PartitionSpecBase.java
M fe/src/main/java/org/apache/impala/analysis/PrivilegeSpec.java
M fe/src/main/java/org/apache/impala/analysis/RangePartition.java
M fe/src/main/java/org/apache/impala/analysis/StatementBase.java
A fe/src/main/java/org/apache/impala/analysis/StmtNode.java
M fe/src/main/java/org/apache/impala/analysis/TableRef.java
M fe/src/main/java/org/apache/impala/analysis/TableSampleClause.java
M fe/src/main/java/org/apache/impala/analysis/TypeDef.java
M fe/src/main/java/org/apache/impala/analysis/WithClause.java
M fe/src/main/java/org/apache/impala/catalog/Type.java
M fe/src/main/java/org/apache/impala/catalog/View.java
M fe/src/main/java/org/apache/impala/service/Frontend.java
M fe/src/test/java/org/apache/impala/analysis/ParserTest.java
M fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FrontendTestBase.java
M fe/src/test/java/org/apache/impala/service/JdbcTest.java
24 files changed, 142 insertions(+), 80 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/12017/1
--
To view, visit http://gerrit.cloudera.org:8080/12017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I39dc783ee1535da5fad8ee2f2dd5f8ca17004bbc
Gerrit-Change-Number: 12017
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12017 )
Change subject: IMPALA-7914: Base interface for statement-like AST nodes
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12017/1/fe/src/main/java/org/apache/impala/analysis/Parser.java
File fe/src/main/java/org/apache/impala/analysis/Parser.java:
http://gerrit.cloudera.org:8080/#/c/12017/1/fe/src/main/java/org/apache/impala/analysis/Parser.java@41
PS1, Line 41: public static StatementBase parse(String query, TQueryOptions options) throws ParseException {
line too long (96 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/12017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39dc783ee1535da5fad8ee2f2dd5f8ca17004bbc
Gerrit-Change-Number: 12017
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Nov 2018 23:50:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes
Posted by "Paul Rogers (Code Review)" <ge...@cloudera.org>.
Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12017 )
Change subject: IMPALA-7914: Base interface for statement-like AST nodes
......................................................................
Abandoned
Wrong branch
--
To view, visit http://gerrit.cloudera.org:8080/12017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I39dc783ee1535da5fad8ee2f2dd5f8ca17004bbc
Gerrit-Change-Number: 12017
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-7914: Base interface for statement-like AST nodes
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12017 )
Change subject: IMPALA-7914: Base interface for statement-like AST nodes
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1491/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12017
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I39dc783ee1535da5fad8ee2f2dd5f8ca17004bbc
Gerrit-Change-Number: 12017
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Rogers <pa...@yahoo.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 01 Dec 2018 00:14:40 +0000
Gerrit-HasComments: No