You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slachiewicz (via GitHub)" <gi...@apache.org> on 2025/04/30 15:18:37 UTC
[PR] Move to org.jline:jansi [maven-shared-utils]
slachiewicz opened a new pull request, #194:
URL: https://github.com/apache/maven-shared-utils/pull/194
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move to org.jline:jansi [maven-shared-utils]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #194:
URL: https://github.com/apache/maven-shared-utils/pull/194#issuecomment-2844188908
I think the switch is only relevant if Maven 3.x switches to JLine too.
Fwiw, the library still works in Maven 4 for Maven 3.x plugins, and it won't be used for plugins using the Maven 4 API, so I'm not really sure we want to go further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move to org.jline:jansi [maven-shared-utils]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #194:
URL: https://github.com/apache/maven-shared-utils/pull/194#discussion_r2068903791
##########
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java:
##########
@@ -78,6 +78,7 @@ public int getTerminalWidth() {
false);
try {
AnsiConsole.systemInstall();
+ // AnsiConsole.out is not available, need to adjust initialization
Review Comment:
how to convert usage of `AnsiOutputStream` in new lib?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move to org.jline:jansi [maven-shared-utils]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #194:
URL: https://github.com/apache/maven-shared-utils/pull/194#discussion_r2068903791
##########
src/test/java/org/apache/maven/shared/utils/logging/MessageUtilsTest.java:
##########
@@ -78,6 +78,7 @@ public int getTerminalWidth() {
false);
try {
AnsiConsole.systemInstall();
+ // AnsiConsole.out is not available, need to adjust initialization
Review Comment:
how to convert usage of `AnsiOutputStream` in new lib @gnodet?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Move to org.jline:jansi [maven-shared-utils]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz closed pull request #194: Move to org.jline:jansi
URL: https://github.com/apache/maven-shared-utils/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org