You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/13 09:58:23 UTC
[GitHub] [hudi] Zouxxyy opened a new pull request, #7190: [HUDI-5200] Clean up resources in hudi common UT
Zouxxyy opened a new pull request, #7190:
URL: https://github.com/apache/hudi/pull/7190
### Change Logs
In the current UT, some resources are not closed, this causes many local disk storage to be occupied
### Impact
Clean up resources in hudi common UT
### Risk level (write none, low medium or high below)
low
### Documentation Update
none
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on PR #7190:
URL: https://github.com/apache/hudi/pull/7190#issuecomment-1312725698
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7190:
URL: https://github.com/apache/hudi/pull/7190#discussion_r1020908718
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieCommonTestHarness.java:
##########
@@ -91,6 +91,12 @@ protected void initMetaClient() throws IOException {
basePath = metaClient.getBasePath();
}
+ protected void cleanMetaClient() {
Review Comment:
you could actually register this with `@AfterEach` ? so that subclasses won't have to call this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7190:
URL: https://github.com/apache/hudi/pull/7190#issuecomment-1312726648
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982",
"triggerID" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"triggerType" : "PUSH"
}, {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12984",
"triggerID" : "1312725698",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0333ad2bc56ab62c8847447f93a91c4c5df0788d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12984)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7190:
URL: https://github.com/apache/hudi/pull/7190#issuecomment-1312697184
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0333ad2bc56ab62c8847447f93a91c4c5df0788d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7190:
URL: https://github.com/apache/hudi/pull/7190#issuecomment-1312698177
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982",
"triggerID" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0333ad2bc56ab62c8847447f93a91c4c5df0788d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7190:
URL: https://github.com/apache/hudi/pull/7190#issuecomment-1312747901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982",
"triggerID" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"triggerType" : "PUSH"
}, {
"hash" : "0333ad2bc56ab62c8847447f93a91c4c5df0788d",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12984",
"triggerID" : "1312725698",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 0333ad2bc56ab62c8847447f93a91c4c5df0788d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12982) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12984)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #7190:
URL: https://github.com/apache/hudi/pull/7190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] Zouxxyy commented on a diff in pull request #7190: [HUDI-5200] Clean up resources in hudi common UT
Posted by GitBox <gi...@apache.org>.
Zouxxyy commented on code in PR #7190:
URL: https://github.com/apache/hudi/pull/7190#discussion_r1020913952
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieCommonTestHarness.java:
##########
@@ -91,6 +91,12 @@ protected void initMetaClient() throws IOException {
basePath = metaClient.getBasePath();
}
+ protected void cleanMetaClient() {
Review Comment:
> you could actually register this with `@AfterEach` ? so that subclasses won't have to call this
There is no `set up` method provided in HoodieCommonTestHarness, the subclass controls the objects that need to be initialized, so the subclass controls the cleanup as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org