You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/05/08 00:33:00 UTC
[jira] [Commented] (KAFKA-8333) Load high watermark checkpoint only
once when handling LeaderAndIsr requests
[ https://issues.apache.org/jira/browse/KAFKA-8333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835216#comment-16835216 ]
ASF GitHub Bot commented on KAFKA-8333:
---------------------------------------
hachikuji commented on pull request #6696: KAFKA-8333; Cache checkpointed high watermarks for reuse on LeaderAndIsr request
URL: https://github.com/apache/kafka/pull/6696
Currently we load the high watermark checkpoint file separately for every partition that is loaded on a broker. This patch adds logic to load the checkpoint file only once when a LeaderAndIsr request is received. The results are reused for all partitions included in the request.
Additionally, this patch removes the dependence on `ReplicaManager` inside `Partition`, which should make testing easier. I have also simplified the future replica loading logic since it was also unnecessarily loading the checkpoint file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Load high watermark checkpoint only once when handling LeaderAndIsr requests
> ----------------------------------------------------------------------------
>
> Key: KAFKA-8333
> URL: https://issues.apache.org/jira/browse/KAFKA-8333
> Project: Kafka
> Issue Type: Bug
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
> Priority: Major
>
> Currently we reload the checkpoint file separately for every partition that is first initialized on the broker. It would be more efficient to do this one time only when we receive the LeaderAndIsr request and to reuse the state.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)